The patch titled
init: properly placing noinline keyword
has been added to the -mm tree. Its filename is
init-properly-placing-noinline-keyword.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: init: properly placing noinline keyword
From: "Rakib Mullick" <rakib.mullick@xxxxxxxxx>
checkpatch warns about 'static void noinline'. It wants `static noinline
void'.
Both are permissible, but the kernel consistently uses `static inline' and
`static noinline', and consistency is good. Hence let's keep the
checkpatch warning and fix up this code site.
[akpm@xxxxxxxxxxxxxxxxxxxx: rewrote changelog]
Signed-off-by: Md.Rakib H. Mullick <rakib.mullick@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
init/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN init/main.c~init-properly-placing-noinline-keyword init/main.c
--- a/init/main.c~init-properly-placing-noinline-keyword
+++ a/init/main.c
@@ -462,7 +462,7 @@ static void __init setup_command_line(ch
* gcc-3.4 accidentally inlines this function, so use noinline.
*/
-static void noinline __init_refok rest_init(void)
+static noinline void __init_refok rest_init(void)
__releases(kernel_lock)
{
int pid;
@@ -863,7 +863,7 @@ int initmem_now_dynamic;
/* This is a non __init function. Force it to be noinline otherwise gcc
* makes it inline to init() and it becomes part of init.text section
*/
-static int noinline init_post(void)
+static noinline int init_post(void)
{
int retry_count = 1;
free_initmem();
_
Patches currently in -mm which might be from rakib.mullick@xxxxxxxxx are
origin.patch
init-properly-placing-noinline-keyword.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
