The patch titled mlocked-pages: add event counting with statistics has been removed from the -mm tree. Its filename was vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics.patch This patch was dropped because it was folded into vmstat-mlocked-pages-statistics.patch The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: mlocked-pages: add event counting with statistics From: Lee Schermerhorn <lee.schermerhorn@xxxxxx> Fix to vmstat-mlocked-pages-statistics.patch Define mlocked pages vm events in the mlocked pages statistics patch. Makes for easier incremental patching. Signed-off-by: Lee Schermerhorn <lee.schermerhorn@xxxxxx> Cc: Lee Schermerhorn <lee.schermerhorn@xxxxxx> Cc: Rik van Riel <riel@xxxxxxxxxx> Cc: Kosaki Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/vmstat.h | 4 ++++ mm/internal.h | 4 +++- mm/mlock.c | 33 +++++++++++++++++++++++++-------- mm/vmstat.c | 4 ++++ 4 files changed, 36 insertions(+), 9 deletions(-) diff -puN include/linux/vmstat.h~vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics include/linux/vmstat.h --- a/include/linux/vmstat.h~vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics +++ a/include/linux/vmstat.h @@ -45,6 +45,10 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS UNEVICTABLE_PGCULLED, /* culled to noreclaim list */ UNEVICTABLE_PGSCANNED, /* scanned for reclaimability */ UNEVICTABLE_PGRESCUED, /* rescued from noreclaim list */ + UNEVICTABLE_PGMLOCKED, + UNEVICTABLE_PGMUNLOCKED, + UNEVICTABLE_PGCLEARED, /* on COW, page truncate */ + UNEVICTABLE_PGSTRANDED, /* unable to isolate on unlock */ #endif NR_VM_EVENT_ITEMS }; diff -puN mm/internal.h~vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics mm/internal.h --- a/mm/internal.h~vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics +++ a/mm/internal.h @@ -101,8 +101,10 @@ static inline int is_mlocked_vma(struct if (likely((vma->vm_flags & (VM_LOCKED | VM_SPECIAL)) != VM_LOCKED)) return 0; - if (!TestSetPageMlocked(page)) + if (!TestSetPageMlocked(page)) { inc_zone_page_state(page, NR_MLOCK); + count_vm_event(UNEVICTABLE_PGMLOCKED); + } return 1; } diff -puN mm/mlock.c~vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics mm/mlock.c --- a/mm/mlock.c~vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics +++ a/mm/mlock.c @@ -61,6 +61,7 @@ void __clear_page_mlock(struct page *pag } dec_zone_page_state(page, NR_MLOCK); + count_vm_event(UNEVICTABLE_PGCLEARED); if (!isolate_lru_page(page)) { putback_lru_page(page); } else { @@ -70,6 +71,9 @@ void __clear_page_mlock(struct page *pag lru_add_drain_all(); if (!isolate_lru_page(page)) putback_lru_page(page); + else if (PageUnevictable(page)) + count_vm_event(UNEVICTABLE_PGSTRANDED); + } } @@ -83,6 +87,7 @@ void mlock_vma_page(struct page *page) if (!TestSetPageMlocked(page)) { inc_zone_page_state(page, NR_MLOCK); + count_vm_event(UNEVICTABLE_PGMLOCKED); if (!isolate_lru_page(page)) putback_lru_page(page); } @@ -113,16 +118,28 @@ static void munlock_vma_page(struct page if (TestClearPageMlocked(page)) { dec_zone_page_state(page, NR_MLOCK); if (!isolate_lru_page(page)) { - try_to_munlock(page); /* maybe relock the page */ + int ret = try_to_munlock(page); + /* + * did try_to_unlock() succeed or punt? + */ + if (ret == SWAP_SUCCESS || ret == SWAP_AGAIN) + count_vm_event(UNEVICTABLE_PGMUNLOCKED); + putback_lru_page(page); + } else { + /* + * We lost the race. let try_to_unmap() deal + * with it. At least we get the page state and + * mlock stats right. However, page is still on + * the noreclaim list. We'll fix that up when + * the page is eventually freed or we scan the + * noreclaim list. + */ + if (PageUnevictable(page)) + count_vm_event(UNEVICTABLE_PGSTRANDED); + else + count_vm_event(UNEVICTABLE_PGMUNLOCKED); } - /* - * Else we lost the race. let try_to_unmap() deal with it. - * At least we get the page state and mlock stats right. - * However, page is still on the noreclaim list. We'll fix - * that up when the page is eventually freed or we scan the - * noreclaim list. - */ } } diff -puN mm/vmstat.c~vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics mm/vmstat.c --- a/mm/vmstat.c~vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics +++ a/mm/vmstat.c @@ -685,6 +685,10 @@ static const char * const vmstat_text[] "unevictable_pgs_culled", "unevictable_pgs_scanned", "unevictable_pgs_rescued", + "unevictable_pgs_mlocked", + "unevictable_pgs_munlocked", + "unevictable_pgs_cleared", + "unevictable_pgs_stranded", #endif #endif }; _ Patches currently in -mm which might be from lee.schermerhorn@xxxxxx are vmscan-use-an-indexed-array-for-lru-variables.patch define-page_file_cache-function.patch vmscan-split-lru-lists-into-anon-file-sets.patch pageflag-helpers-for-configed-out-flags.patch unevictable-lru-infrastructure.patch unevictable-infrastructure-lru-add-event-counting-with-statistics.patch unevictable-lru-page-statistics.patch ramfs-and-ram-disk-pages-are-unevictable.patch shm_locked-pages-are-unevictable.patch mlock-mlocked-pages-are-unevictable.patch doc-unevictable-lru-and-mlocked-pages-documentation.patch mlock-downgrade-mmap-sem-while-populating-mlocked-regions.patch mmap-handle-mlocked-pages-during-map-remap-unmap.patch vmstat-mlocked-pages-statistics.patch vmstat-mlocked-pages-statistics-mlocked-pages-add-event-counting-with-statistics.patch swap-cull-unevictable-pages-in-fault-path.patch vmscan-unevictable-lru-scan-sysctl.patch mlock-count-attempts-to-free-mlocked-page-2.patch mlock-revert-mainline-handling-of-mlock-error-return.patch mlock-make-mlock-error-return-posixly-correct.patch mlock-make-mlock-error-return-posixly-correct-fix.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html