The patch titled
nfs: BUG_ON in nfs_follow_mountpoint
has been removed from the -mm tree. Its filename was
nfs-bug_on-in-nfs_follow_mountpoint.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: nfs: BUG_ON in nfs_follow_mountpoint
From: "Denis V. Lunev" <den@xxxxxxxxxx>
Unfortunately, BUG_ON(IS_ROOT(dentry)) can happen inside
nfs_follow_mountpoint with NFS running Fedora 8 using a specific setup.
See https://bugzilla.redhat.com/show_bug.cgi?id=458622
So the situation should be handled on NFS client gracefully.
(Trond:
I'm not convinced that ESTALE is the correct error to return to the
user. ESTALE has a very precise meaning in the NFS protocol: it tells
you that access to the object has been revoked.
That again means either that either the object has been deleted, or it
is no longer exported by the server to this client.
In the case referred to by Denis, the source of the bug is a broken
server, and so I'd expect that EIO is probably more appropriate.)
Signed-off-by: Denis V. Lunev <den@xxxxxxxxxx>
Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
Cc: J. Bruce Fields <bfields@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/nfs/namespace.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff -puN fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint fs/nfs/namespace.c
--- a/fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint
+++ a/fs/nfs/namespace.c
@@ -105,7 +105,10 @@ static void * nfs_follow_mountpoint(stru
dprintk("--> nfs_follow_mountpoint()\n");
- BUG_ON(IS_ROOT(dentry));
+ err = -ESTALE;
+ if (IS_ROOT(dentry))
+ goto out_err;
+
dprintk("%s: enter\n", __func__);
dput(nd->path.dentry);
nd->path.dentry = dget(dentry);
_
Patches currently in -mm which might be from den@xxxxxxxxxx are
git-nfs.patch
git-net.patch
dontdiff-more-updates-to-be-closer-to-gitignore.patch
proc-use-non-racy-method-for-proc-page_owner-creation-page_owner.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
