The patch titled
mm: do_generic_file_read() never gets a NULL 'filp' argument
has been added to the -mm tree. Its filename is
mm-do_generic_file_read-never-gets-a-null-filp-argument.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mm: do_generic_file_read() never gets a NULL 'filp' argument
From: Krishna Kumar <krkumar2@xxxxxxxxxx>
The 'filp' argument to do_generic_file_read() is never NULL.
Signed-off-by: Krishna Kumar <krkumar2@xxxxxxxxxx>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/filemap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -puN mm/filemap.c~mm-do_generic_file_read-never-gets-a-null-filp-argument mm/filemap.c
--- a/mm/filemap.c~mm-do_generic_file_read-never-gets-a-null-filp-argument
+++ a/mm/filemap.c
@@ -1187,8 +1187,7 @@ out:
ra->prev_pos |= prev_offset;
*ppos = ((loff_t)index << PAGE_CACHE_SHIFT) + offset;
- if (filp)
- file_accessed(filp);
+ file_accessed(filp);
}
int file_read_actor(read_descriptor_t *desc, struct page *page,
_
Patches currently in -mm which might be from krkumar2@xxxxxxxxxx are
mm-do_generic_file_read-never-gets-a-null-filp-argument.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
