The patch titled
mm: oom-killer kills more than needed
has been removed from the -mm tree. Its filename was
mm-oom-killer-kills-more-than-needed.patch
This patch was dropped because an updated version will be merged
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mm: oom-killer kills more than needed
From: "Chad Zanonie" <chad.zanonie@xxxxxxxxx>
Possibility exists for an exiting application to be in between marking its
mm NULL and calling mmput when out_of_memory is invoked.
select_bad_process() will continue past this process as opposed to
returning -1UL due to its mm being NULL. This causes the oom killer in
certain scenarios to not only kill the memory culprit, but also kill the
runner up.
EXIT_DEAD seems to be the only flag that guarantees that mmput() has
finished. Checking for PF_KTHREAD should replace p->mm regardless.
Adding EXIT_DEAD to the check seems to prevent unnecessary kills in local
testing.
Signed-off-by: Chad Zanonie <chad.zanonie@xxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Nick Piggin <npiggin@xxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/oom_kill.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/oom_kill.c~mm-oom-killer-kills-more-than-needed mm/oom_kill.c
--- a/mm/oom_kill.c~mm-oom-killer-kills-more-than-needed
+++ a/mm/oom_kill.c
@@ -216,7 +216,7 @@ static struct task_struct *select_bad_pr
* skip kernel threads and tasks which have already released
* their mm.
*/
- if (!p->mm)
+ if (p->flags & PF_KTHREAD || p->flags & EXIT_DEAD)
continue;
/* skip the init task */
if (is_global_init(p))
_
Patches currently in -mm which might be from chad.zanonie@xxxxxxxxx are
mm-oom-killer-kills-more-than-needed.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
