The patch titled
pci: fix MSI-HOWTO.txt info about MSI-X MMIO space
has been added to the -mm tree. Its filename is
pci-fix-msi-howtotxt-info-about-msi-x-mmio-space.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: pci: fix MSI-HOWTO.txt info about MSI-X MMIO space
From: Roland Dreier <roland@xxxxxxxxxxxxxxxxxx>
The current MSI-HOWTO.txt says that device drivers should not request the
memory space that contains MSI-X tables. This is because the original
MSI-X implementation did a request_mem_region() on this space, but that
code was removed long ago (in the pre-git era, in fact). Years after the
code was changed, we might as well clean up the documention to avoid a
confusing mention of requesting regions: drivers using MSI-X can just use
pci_request_regions() just like any other driver, and so there's no need
for MSI-HOWTO.txt to talk about this at all.
Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
Documentation/MSI-HOWTO.txt | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff -puN Documentation/MSI-HOWTO.txt~pci-fix-msi-howtotxt-info-about-msi-x-mmio-space Documentation/MSI-HOWTO.txt
--- a/Documentation/MSI-HOWTO.txt~pci-fix-msi-howtotxt-info-about-msi-x-mmio-space
+++ a/Documentation/MSI-HOWTO.txt
@@ -236,10 +236,8 @@ software system can set different pages
MSI-X structure. The implementation of MSI support requires the PCI
subsystem, not a device driver, to maintain full control of the MSI-X
table/MSI-X PBA (Pending Bit Array) and MMIO address space of the MSI-X
-table/MSI-X PBA. A device driver is prohibited from requesting the MMIO
-address space of the MSI-X table/MSI-X PBA. Otherwise, the PCI subsystem
-will fail enabling MSI-X on its hardware device when it calls the function
-pci_enable_msix().
+table/MSI-X PBA. A device driver should not access the MMIO address
+space of the MSI-X table/MSI-X PBA.
5.3.2 API pci_enable_msix
_
Patches currently in -mm which might be from roland@xxxxxxxxxxxxxxxxxx are
pci-fix-msi-howtotxt-info-about-msi-x-mmio-space.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
