The patch titled w1-new-driver-ds2431-chip-fix has been added to the -mm tree. Its filename is w1-new-driver-ds2431-chip-fix.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: w1-new-driver-ds2431-chip-fix From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Ben Gardner <bgardner@xxxxxxxxxx> Cc: Bernhard Weirich <bernhard.weirich@xxxxxxxxxx> Cc: Evgeniy Polyakov <johnpol@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/w1/slaves/w1_ds2431.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff -puN drivers/w1/slaves/w1_ds2431.c~w1-new-driver-ds2431-chip-fix drivers/w1/slaves/w1_ds2431.c --- a/drivers/w1/slaves/w1_ds2431.c~w1-new-driver-ds2431-chip-fix +++ a/drivers/w1/slaves/w1_ds2431.c @@ -1,5 +1,5 @@ /* - * w1_DS2431.c - w1 family 2d (DS2431) driver + * w1_ds2431.c - w1 family 2d (DS2431) driver * * Copyright (c) 2008 Bernhard Weirich <bernhard.weirich@xxxxxxxxxx> * @@ -41,7 +41,7 @@ #define W1_F2D_READ_RETRIES 10 #define W1_F2D_READ_MAXLEN 8 -/** +/* * Check the file size bounds and adjusts count as needed. * This would not be needed if the file size didn't reset to 0 after a write. */ @@ -56,7 +56,7 @@ static inline size_t w1_f2d_fix_count(lo return count; } -/** +/* * Read a block from W1 ROM two times and compares the results. * If they are equal they are returned, otherwise the read * is repeated W1_F2D_READ_RETRIES times. @@ -88,8 +88,6 @@ static int w1_f2d_readblock(struct w1_sl if (!memcmp(cmp, buf, count)) return 0; - - } while (--tries); dev_err(&sl->dev, "proof reading failed %d times\n", @@ -98,7 +96,6 @@ static int w1_f2d_readblock(struct w1_sl return -1; } - static ssize_t w1_f2d_read_bin(struct kobject *kobj, struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count) @@ -134,7 +131,7 @@ static ssize_t w1_f2d_read_bin(struct ko return count; } -/** +/* * Writes to the scratchpad and reads it back for verification. * Then copies the scratchpad to EEPROM. * The data must be aligned at W1_F2D_SCRATCH_SIZE bytes and @@ -279,10 +276,7 @@ static struct bin_attribute w1_f2d_bin_a static int w1_f2d_add_slave(struct w1_slave *sl) { - int err; - err = sysfs_create_bin_file(&sl->dev.kobj, &w1_f2d_bin_attr); - - return err; + return sysfs_create_bin_file(&sl->dev.kobj, &w1_f2d_bin_attr); } static void w1_f2d_remove_slave(struct w1_slave *sl) _ Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are origin.patch include-linux-ioporth-add-missing-macro-argument-for-devm_release_-family.patch rescan_partitions-make-device-capacity-errors-non-fatal.patch linux-next.patch linux-next-fixups.patch next-remove-localversion.patch drivers-mfd-ucb1400_corec-needs-gpio.patch drivers-mfd-ucb1400_corec-further-unbork.patch revert-acpi-ec-do-transaction-from-interrupt-context.patch acpi-catch-calls-of-acpi_driver_data-on-pointer-of-wrong-type-fix.patch acpi-catch-calls-of-acpi_driver_data-on-pointer-of-wrong-type-fix-fix.patch zero-based-percpu-use-vmlinux_symbol-in-include-asm-generic-vmlinuxldsh.patch arch-x86-kernel-early_printkc-remove-unused-enable_debug_console.patch tick-schedc-suppress-needless-timer-reprogramming.patch drivers-input-touchscreen-ucb1400_tsc-needs-gpio.patch git-jg-misc.patch led-driver-for-leds-on-pcengines-alix2-and-alix3-boards.patch libata-blackfin-pata-driver-add-proper-pm-operation-into-atapi-driver-fix.patch sundance-set-carrier-status-on-link-change-events.patch cassini-use-request_firmware.patch e1000e-avoid-duplicated-output-of-device-name-in-kernel-warning-checkpatch-fixes.patch e1000e-avoid-duplicated-output-of-device-name-in-kernel-warning-fix.patch backlight-driver-for-tabletkiosk-sahara-touchit-213-tablet-pc.patch backlight-driver-for-tabletkiosk-sahara-touchit-213-tablet-pc-update-2-checkpatch-fixes.patch fix-cred-wrap-current-cred-and-a-few-other-accessors-on-mips.patch pci-tidy-pme-support-messages-checkpatch-fixes.patch sched-clarify-ifdef-tangle.patch debug_locks_warn_on-disable-if-oops_in_progress.patch scsi-gdthc-use-unaligned-access-helpers.patch drivers-scsi-device_handler-scsi_dh_emcc-suppress-warning.patch drivers-rtc-kconfig-dont-build-rtc-cmoso-on-sparc32.patch drivers-usb-musb-disable-it-on-superh.patch git-xtensa.patch scsi-dpt_i2o-is-bust-on-ia64.patch drivers-media-video-cafe_ccicc-needs-mmh.patch e1000e-prevent-corruption-of-eeprom-nvm.patch drivers-net-mlx4-allocc-needs-mmh.patch net-forcedeth-call-restore-mac-addr-in-nv_shutdown-path-v2.patch mm-page_allocc-free_area_init_nodes-fix-inappropriate-use-of-enum.patch mm-cleanup-to-make-remove_memory-arch-neutral-fix.patch mm-tiny-shmem-fix-lor-mmap_sem-vs-i_mutex-checkpatch-fixes.patch vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch vm-dont-run-touch_buffer-during-buffercache-lookups.patch vmscan-move-isolate_lru_page-to-vmscanc.patch define-page_file_cache-function.patch vmscan-split-lru-lists-into-anon-file-sets.patch unevictable-lru-infrastructure.patch unevictable-lru-page-statistics.patch mlock-mlocked-pages-are-unevictable.patch mlock-mlocked-pages-are-unevictable-fix.patch mmap-handle-mlocked-pages-during-map-remap-unmap.patch mmap-handle-mlocked-pages-during-map-remap-unmap-mlock-resubmit-locked_vm-adjustment-as-separate-patch-fix.patch vmscan-unevictable-lru-scan-sysctl.patch mlock-make-mlock-error-return-posixly-correct-fix.patch mm-rewrite-vmap-layer-fix.patch mm-rewrite-vmap-layer-fix-fix.patch mm-rewrite-vmap-layer-fix-fix-fix.patch h8300-generic_bug-support-checkpatch-fixes.patch pm-rework-disabling-of-user-mode-helpers-during-suspend-hibernation-cleanup.patch container-freezer-add-tif_freeze-flag-to-all-architectures-fix.patch container-freezer-implement-freezer-cgroup-subsystem-checkpatch-fixes.patch container-freezer-implement-freezer-cgroup-subsystem-uninline-thaw_process-fix.patch separate-atomic_t-declaration-from-asm-atomich-into-asm-atomic_defh-fix.patch separate-atomic_t-declaration-from-asm-atomich-into-asm-atomic_defh-fix-fix.patch fix-a-race-condtion-of-oops_in_progress-fix.patch vsprintf-use-new-vsprintf-symbolic-function-pointer-format-cleanup.patch make-taint-bit-reliable-v3-fix.patch kernel-sysc-improve-code-generation.patch compat-generic-compat-get-settimeofday-checkpatch-fixes.patch hwmon-pc87360-separate-alarm-files-add-in-min-max-alarms-cleanup.patch hwmon-pc87360-separate-alarm-files-add-temp-min-max-crit-fault-alarms-cleanup.patch hwmon-pc87360-separate-alarm-files-add-therm-min-max-crit-alarms-cleanup.patch allow-recursion-in-binfmt_script-and-binfmt_misc-fix.patch autofs4-track-uid-and-gid-of-last-mount-requester-fix.patch autofs4-add-miscellaneous-device-for-ioctls-fix.patch autofs4-add-miscellaneous-device-for-ioctls-fix-2.patch autofs4-add-miscellaneous-device-for-ioctls-fix-fix-3.patch rtc-add-device-driver-for-dallas-ds3234-spi-rtc-chip-fix.patch fb-push-down-the-bkl-in-the-ioctl-handler-checkpatch-fixes.patch viafb-viafbmodes-viafbtxt-fix-fix.patch viafb-accelc-accelh-checkpatch-fixes.patch viafb-dvic-dvih-globalc-and-globalh-checkpatch-fixes.patch viafb-hwc-hwh-checkpatch-fixes.patch viafb-viafbdevc-viafbdevh-checkpatch-fixes.patch fbdev-kconfig-update-fix.patch eink_apollofb-new-driver-for-apollo-eink-controller.patch ext2-avoid-printk-floods-in-the-face-of-directory-corruption-checkpatch-fixes.patch ext3-fix-ext3_dx_readdir-hash-collision-handling-checkpatch-fixes.patch cgroups-fix-probable-race-with-put_css_set-and-find_css_set-fix.patch memrlimit-add-memrlimit-controller-accounting-and-control-mm_owner-fix-checkpatch-fixes.patch genirq-record-trigger-type-fix.patch message-queues-increase-range-limits-checkpatch-fixes.patch tty-fix-echo-tab-erase-and-locking-fix.patch applicomc-fix-apparently-broken-code-in-do_ac_read.patch drivers-char-tpm-tpmc-fix-error-patch-memory-leak.patch w1-be-able-to-manually-add-and-remove-slaves-fix.patch w1-new-driver-ds2431-chip-fix.patch gru-driver-minor-updates-fix.patch gcov-architecture-specific-compile-flag-adjustments-powerpc-moved-stuff.patch drivers-rtc-rtc-bq4802c-dont-use-bin_2_bcd-and-bcd_2_bin.patch x86-sysfs-kill-owner-field-from-attribute-fix.patch reiser4.patch reiser4-tree_lock-fixes.patch reiser4-tree_lock-fixes-fix.patch reiser4-semaphore-fix.patch slb-drop-kmem-cache-argument-from-constructor-reiser4.patch reiser4-suid.patch reiser4-track-upstream-changes.patch page-owner-tracking-leak-detector.patch nr_blockdev_pages-in_interrupt-warning.patch slab-leaks3-default-y.patch put_bh-debug.patch shrink_slab-handle-bad-shrinkers.patch getblk-handle-2tb-devices.patch getblk-handle-2tb-devices-fix.patch undeprecate-pci_find_device.patch notify_change-callers-must-hold-i_mutex.patch profile-likely-unlikely-macros.patch drivers-net-bonding-bond_sysfsc-suppress-uninitialized-var-warning.patch w1-build-fix.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html