The patch titled
anysee: initialize anysee_usb_mutex statically
has been added to the -mm tree. Its filename is
anysee-initialize-anysee_usb_mutex-statically.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: anysee: initialize anysee_usb_mutex statically
From: Akinobu Mita <akinobu.mita@xxxxxxxxx>
anysee_usb_mutex is initialized at every time the anysee device is probed.
If the second anysee device is probed while anysee_usb_mutex is locked by
the first anysee device, the mutex is broken.
This patch fixes by initialize anysee_usb_mutex statically rather
than initialize at probe time.
Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
Cc: v4l-dvb-maintainer@xxxxxxxxxxx
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/media/dvb/dvb-usb/anysee.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff -puN drivers/media/dvb/dvb-usb/anysee.c~anysee-initialize-anysee_usb_mutex-statically drivers/media/dvb/dvb-usb/anysee.c
--- a/drivers/media/dvb/dvb-usb/anysee.c~anysee-initialize-anysee_usb_mutex-statically
+++ a/drivers/media/dvb/dvb-usb/anysee.c
@@ -43,7 +43,7 @@ module_param_named(debug, dvb_usb_anysee
MODULE_PARM_DESC(debug, "set debugging level" DVB_USB_DEBUG_STATUS);
DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
-static struct mutex anysee_usb_mutex;
+static DEFINE_MUTEX(anysee_usb_mutex);
static int anysee_ctrl_msg(struct dvb_usb_device *d, u8 *sbuf, u8 slen,
u8 *rbuf, u8 rlen)
@@ -436,8 +436,6 @@ static int anysee_probe(struct usb_inter
struct usb_host_interface *alt;
int ret;
- mutex_init(&anysee_usb_mutex);
-
/* There is one interface with two alternate settings.
Alternate setting 0 is for bulk transfer.
Alternate setting 1 is for isochronous transfer.
_
Patches currently in -mm which might be from akinobu.mita@xxxxxxxxx are
ibmasr-remove-unnecessary-spin_unlock.patch
linux-next.patch
mmc_block-handle-error-from-mmc_register_driver.patch
mmc_test-initialize-mmc_test_lock-statically.patch
anysee-initialize-anysee_usb_mutex-statically.patch
ipr-use-memory_read_from_buffer.patch
char-merge-ip2main-and-ip2base.patch
char-ip2-cleanup-globals.patch
char-ip2-fix-sparse-warnings.patch
char-ip2-init-deinit-cleanup.patch
ip2-avoid-add_timer-with-pending-timer.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
