The patch titled
drivers/usb/misc: Use an IS_ERR test rather than a NULL test
has been removed from the -mm tree. Its filename was
drivers-usb-misc-use-an-is_err-test-rather-than-a-null-test.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: drivers/usb/misc: Use an IS_ERR test rather than a NULL test
From: Julien Brunel <brunel@xxxxxxx>
In case of error, the function backlight_device_register returns an
ERR pointer, but never returns a NULL pointer. So a NULL test that may
come after a call to this function should be strengthened by an IS_ERR
test.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@match_bad_null_test@
expression x, E;
statement S1,S2;
@@
x = backlight_device_register(...)
... when != x = E
* if (x != NULL)
S1 else S2
// </smpl>
Signed-off-by: Julien Brunel <brunel@xxxxxxx>
Signed-off-by: Julia Lawall <julia@xxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/usb/misc/appledisplay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/usb/misc/appledisplay.c~drivers-usb-misc-use-an-is_err-test-rather-than-a-null-test drivers/usb/misc/appledisplay.c
--- a/drivers/usb/misc/appledisplay.c~drivers-usb-misc-use-an-is_err-test-rather-than-a-null-test
+++ a/drivers/usb/misc/appledisplay.c
@@ -314,7 +314,7 @@ error:
pdata->urbdata, pdata->urb->transfer_dma);
usb_free_urb(pdata->urb);
}
- if (pdata->bd)
+ if (pdata->bd && !IS_ERR(pdata->bd))
backlight_device_unregister(pdata->bd);
kfree(pdata->msgdata);
}
_
Patches currently in -mm which might be from brunel@xxxxxxx are
linux-next.patch
fs-9p-use-an-is_err-test-rather-than-a-null-test.patch
checkpatch-suppress-errors-triggered-by-short-patch.patch
fs-reiserfs-use-an-is_err-test-rather-than-a-null-test.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
