+ vmscan-set-try_to_release_pages-gfp_mask-to-0.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     vmscan: set try_to_release_page's gfp_mask to 0
has been added to the -mm tree.  Its filename is
     vmscan-set-try_to_release_pages-gfp_mask-to-0.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: vmscan: set try_to_release_page's gfp_mask to 0
From: Hisashi Hifumi <hifumi.hisashi@xxxxxxxxxxxxx>

shrink_page_list() passes a gfp_mask to try_to_release_page.  When
shrink_page_list is called from kswapd or buddy system, gfp_mask is set
and (gfp_mask & __GFP_WAIT) and (gfp_mask & __GFP_FS) check is positive. 
releasepage of jbd/jbd2(ext3/4, ocfs2) and XFS use this parameter.

If try_to_free_page fails due to bh busy in jbd/jbd2, jbd/jbd2 lets a
thread wait for committing transaction.  I think this has big performance
impacts for vmscan.  So I modified shrink_page_list not to pass gfp_mask
to try_to_release_page in ordered to improve vmscan performance.

Signed-off-by: Hisashi Hifumi <hifumi.hisashi@xxxxxxxxxxxxx>
Cc: Mingming Cao <cmm@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 mm/vmscan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN mm/vmscan.c~vmscan-set-try_to_release_pages-gfp_mask-to-0 mm/vmscan.c
--- a/mm/vmscan.c~vmscan-set-try_to_release_pages-gfp_mask-to-0
+++ a/mm/vmscan.c
@@ -614,7 +614,7 @@ static unsigned long shrink_page_list(st
 		 * Otherwise, leave the page on the LRU so it is swappable.
 		 */
 		if (PagePrivate(page)) {
-			if (!try_to_release_page(page, sc->gfp_mask))
+			if (!try_to_release_page(page, 0))
 				goto activate_locked;
 			if (!mapping && page_count(page) == 1) {
 				unlock_page(page);
_

Patches currently in -mm which might be from hifumi.hisashi@xxxxxxxxxxxxx are

vmscan-set-try_to_release_pages-gfp_mask-to-0.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux