The patch titled W1: w1_therm consistent mutex access code cleanup has been added to the -mm tree. Its filename is w1-w1_therm-consistent-mutex-access-code-cleanup.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: W1: w1_therm consistent mutex access code cleanup From: David Fries <david@xxxxxxxxx> sl->master->mutex and dev->mutex refer to the same mutex variable, but be consistent and use the same set of pointers for the lock and unlock calls. It is less confusing (and one less pointer dereference this way). Signed-off-by: David Fries <david@xxxxxxxxx> Signed-off-by: Evgeniy Polyakov <johnpol@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/w1/slaves/w1_therm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/w1/slaves/w1_therm.c~w1-w1_therm-consistent-mutex-access-code-cleanup drivers/w1/slaves/w1_therm.c --- a/drivers/w1/slaves/w1_therm.c~w1-w1_therm-consistent-mutex-access-code-cleanup +++ a/drivers/w1/slaves/w1_therm.c @@ -171,7 +171,7 @@ static ssize_t w1_therm_read(struct devi int i, max_trying = 10; ssize_t c = PAGE_SIZE; - mutex_lock(&sl->master->mutex); + mutex_lock(&dev->mutex); memset(rom, 0, sizeof(rom)); _ Patches currently in -mm which might be from david@xxxxxxxxx are w1-fix-deadlocks-and-remove-w1_control_thread.patch w1-abort-search-early-on-on-exit.patch w1-dont-delay-search-start.patch w1-w1_process-block-or-sleep.patch w1-feature-enable-hardware-strong-pullup.patch w1-feature-w1_thermc-use-strong-pullup-and-documentation.patch w1-be-able-to-manually-add-and-remove-slaves.patch w1-recode-w1_slave_found-logic.patch w1-new-module-parameter-search_count.patch w1-document-add-remove-search_count-and-pullup.patch w1-w1_slave_read_id-read-bug-use-device_attribute.patch w1-w1_therm-fix-user-buffer-overflow-and-cat.patch w1-w1_family-remove-unused-variable-need_exit.patch w1-w1_therm-consistent-mutex-access-code-cleanup.patch w1-w1_intc-use-first-available-master-number.patch w1-w1c-s-printk-dev_dbg.patch w1-w1_ioc-reset-comments-and-msleep.patch w1-ds1wmc-msleep-for-reset.patch w1-ds2490c-correct-print-message.patch w1-ds2490c-add-support-for-strong-pullup.patch w1-ds2490c-ds_write_bit-grouping-error-disable-readback.patch w1-ds2490c-disable-bit-read-and-write.patch w1-ds2490c-simplify-and-fix-ds_touch_bit.patch w1-ds2490c-ds_dump_status-rework.patch w1-ds2490c-ds_reset-remove-ds_wait_status.patch w1-ds2490c-reset-ds2490-in-init.patch w1-ds2490c-magic-number-work.patch w1-ds2490c-ds_write_block-remove-extra-ds_wait_status.patch w1-documentation-w1-masters-ds2490-update.patch w1-ds2490c-optimize-ds_set_pullup.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html