The patch titled
drivers/net/wireless/b43legacy/main.c: release mutex in error handling code
has been added to the -mm tree. Its filename is
drivers-net-wireless-b43legacy-mainc-release-mutex-in-error-handling-code.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: drivers/net/wireless/b43legacy/main.c: release mutex in error handling code
From: Julia Lawall <julia@xxxxxxx>
The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.
The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression l;
@@
mutex_lock(l);
... when != mutex_unlock(l)
when any
when strict
(
if (...) { ... when != mutex_unlock(l)
+ mutex_unlock(l);
return ...;
}
|
mutex_unlock(l);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@xxxxxxx>
Cc: John W. Linville <linville@xxxxxxxxxxxxx>
Cc: Stefano Brivio <stefano.brivio@xxxxxxxxx>
Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
Cc: Michael Buesch <mb@xxxxxxxxx>
Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/net/wireless/b43legacy/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/wireless/b43legacy/main.c~drivers-net-wireless-b43legacy-mainc-release-mutex-in-error-handling-code drivers/net/wireless/b43legacy/main.c
--- a/drivers/net/wireless/b43legacy/main.c~drivers-net-wireless-b43legacy-mainc-release-mutex-in-error-handling-code
+++ a/drivers/net/wireless/b43legacy/main.c
@@ -3846,10 +3846,10 @@ static int b43legacy_resume(struct ssb_d
goto out;
}
}
- mutex_unlock(&wl->mutex);
b43legacydbg(wl, "Device resumed.\n");
out:
+ mutex_unlock(&wl->mutex);
return err;
}
_
Patches currently in -mm which might be from julia@xxxxxxx are
origin.patch
linux-next.patch
drivers-net-ehea-ehea_mainc-release-mutex-in-error-handling-code.patch
drivers-net-wireless-b43legacy-mainc-release-mutex-in-error-handling-code.patch
net-ieee80211-adjust-error-handling.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
