The patch titled
pm: serio: speed up resume
has been added to the -mm tree. Its filename is
pm-serio-speed-up-resume.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: pm: serio: speed up resume
From: Shaohua Li <shaohua.li@xxxxxxxxx>
Subject: serio: Speed-up resume
serio_resume will call into psmouse_extensions(). In my test, the
routine is very slow, it blocks resume about 1 sec. Below patch (move
resume to kseriod, just like boot time probe) cures the issue in my
test, and seems no side effect. I'm no familiar with serio driver, so
please check.
Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>
Acked-by: Len Brown <lenb@xxxxxxxxxx>
Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
Cc: Dmitry Torokhov <dtor@xxxxxxx>
Acked-by: Pavel Machek <pavel@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/input/serio/serio.c | 33 +++++++++++++++++++++++++--------
1 file changed, 25 insertions(+), 8 deletions(-)
diff -puN drivers/input/serio/serio.c~pm-serio-speed-up-resume drivers/input/serio/serio.c
--- a/drivers/input/serio/serio.c~pm-serio-speed-up-resume
+++ a/drivers/input/serio/serio.c
@@ -163,6 +163,7 @@ enum serio_event_type {
SERIO_RECONNECT_PORT,
SERIO_REGISTER_PORT,
SERIO_ATTACH_DRIVER,
+ SERIO_RESUME_PORT,
};
struct serio_event {
@@ -287,6 +288,13 @@ static struct serio_event *serio_get_eve
return event;
}
+#ifdef CONFIG_PM
+static void serio_resume_port(struct device *dev);
+#else
+static inline void serio_resume_port(struct device *dev)
+{
+}
+#endif /* CONFIG_PM */
static void serio_handle_event(void)
{
struct serio_event *event;
@@ -319,6 +327,10 @@ static void serio_handle_event(void)
serio_attach_driver(event->object);
break;
+ case SERIO_RESUME_PORT:
+ serio_resume_port(event->object);
+ break;
+
default:
break;
}
@@ -925,21 +937,26 @@ static int serio_suspend(struct device *
return 0;
}
-static int serio_resume(struct device *dev)
+static void serio_resume_port(struct device *dev)
{
struct serio *serio = to_serio_port(dev);
- if (dev->power.power_state.event != PM_EVENT_ON &&
- serio_reconnect_driver(serio)) {
- /*
- * Driver re-probing can take a while, so better let kseriod
- * deal with it.
- */
- serio_rescan(serio);
+ if (serio_reconnect_driver(serio)) {
+ serio_disconnect_port(serio);
+ serio_find_driver(serio);
}
dev->power.power_state = PMSG_ON;
+}
+static int serio_resume(struct device *dev)
+{
+ /*
+ * Driver reconnect can take a while, so better let kseriod
+ * deal with it.
+ */
+ if (dev->power.power_state.event != PM_EVENT_ON)
+ serio_queue_event(dev, NULL, SERIO_RESUME_PORT);
return 0;
}
#endif /* CONFIG_PM */
_
Patches currently in -mm which might be from shaohua.li@xxxxxxxxx are
linux-next.patch
pm-serio-speed-up-resume.patch
pm-acpi-hibernation-utilize-hardware-signature.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
