The patch titled cpusets: restructure the function update_cpumask() and update_nodemask() fix has been added to the -mm tree. Its filename is cpusets-restructure-the-function-update_cpumask-and-update_nodemask-fix.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: cpusets: restructure the function update_cpumask() and update_nodemask() fix From: Li Zefan <lizf@xxxxxxxxxxxxxx> >> kernel/cpuset.c: In function 'cpuset_write_resmask': >> kernel/cpuset.c:1374: warning: passing argument 2 of 'update_nodemask' discards qualifiers from pointer target type >> >> Did you not get this warning also? >> >> I don't know how to fix it. cftype.write_string() requires a const >> char* in the third arg, but we then go on to call update_nodemask(), >> which does a strstrip() on this allegedly-const char array. >> > > That strstrip() should be removed. because cgroup_write_string() already strstrip()ed > the buffer. Paul M's original patch removed that 2 strstrip()s in cpuset.c. > Here is the patch: Cc: Miao Xie <miaox@xxxxxxxxxxxxxx> Cc: Paul Jackson <pj@xxxxxxx> Cc: David Rientjes <rientjes@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/cpuset.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -puN kernel/cpuset.c~cpusets-restructure-the-function-update_cpumask-and-update_nodemask-fix kernel/cpuset.c --- a/kernel/cpuset.c~cpusets-restructure-the-function-update_cpumask-and-update_nodemask-fix +++ a/kernel/cpuset.c @@ -1011,7 +1011,7 @@ done: * lock each such tasks mm->mmap_sem, scan its vma's and rebind * their mempolicies to the cpusets new mems_allowed. */ -static int update_nodemask(struct cpuset *cs, char *buf) +static int update_nodemask(struct cpuset *cs, const char *buf) { struct cpuset trialcs; nodemask_t oldmem; @@ -1032,7 +1032,6 @@ static int update_nodemask(struct cpuset * that parsing. The validate_change() call ensures that cpusets * with tasks have memory. */ - buf = strstrip(buf); if (!*buf) { nodes_clear(trialcs.mems_allowed); } else { _ Patches currently in -mm which might be from lizf@xxxxxxxxxxxxxx are cgroups-document-the-effect-of-attaching-pid-0-to-a-cgroup.patch cgroups-document-the-effect-of-attaching-pid-0-to-a-cgroup-fix.patch doc-document-the-relax_domain_level-kernel-boot-argument.patch doc-document-the-relax_domain_level-kernel-boot-argument-fix.patch linux-next.patch hugetlb-reservations-fix-hugetlb-map_private-reservations-across-vma-splits-v2-fix.patch call_usermodehelper-increase-reliability.patch mfd-sm501-build-fixes-when-config_mfd_sm501_gpio-unset.patch rtc-push-the-bkl-down-into-the-driver-ioctl-method-fix.patch ext3-kill-2-useless-magic-numbers.patch cgroup-use-read-lock-to-guard-find_existing_css_set.patch cgroup-list_for_each-cleanup-v2.patch cgroup-anotate-two-variables-with-__read_mostly.patch cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler-fix.patch memcg-avoid-unnecessary-initialization.patch memcg-better-migration-handling.patch memcg-remove-refcnt-from-page_cgroup.patch memcg-remove-refcnt-from-page_cgroup-fix.patch memcg-remove-refcnt-from-page_cgroup-fix-2.patch memcg-remove-refcnt-from-page_cgroup-fix-memcg-fix-mem_cgroup_end_migration-race.patch memcg-remove-refcnt-from-page_cgroup-memcg-fix-shmem_unuse_inode-charging.patch memcg-handle-swap-cache.patch memcg-handle-swap-cache-fix.patch memcg-handle-swap-cache-fix-shmem-page-migration-incorrectness-on-memcgroup.patch memcg-helper-function-for-relcaim-from-shmem.patch memcg-helper-function-for-relcaim-from-shmem-memcg-shmem_getpage-release-page-sooner.patch memcg-helper-function-for-relcaim-from-shmem-memcg-mem_cgroup_shrink_usage-css_put.patch memcg-add-hints-for-branch.patch memcg-remove-a-redundant-check.patch memcg-clean-up-checking-of-the-disabled-flag.patch memcg-clean-up-checking-of-the-disabled-flag-memcg-further-checking-of-disabled-flag.patch memrlimit-add-memrlimit-controller-documentation.patch memrlimit-setup-the-memrlimit-controller.patch memrlimit-setup-the-memrlimit-controller-memrlimit-correct-mremap-and-move_vma-accounting.patch memrlimit-cgroup-mm-owner-callback-changes-to-add-task-info.patch memrlimit-cgroup-mm-owner-callback-changes-to-add-task-info-memrlimit-fix-sleep-inside-sleeplock-in-mm_update_next_owner.patch memrlimit-add-memrlimit-controller-accounting-and-control.patch memrlimit-add-memrlimit-controller-accounting-and-control-memrlimit-improve-fork-and-error-handling.patch memrlimit-improve-error-handling.patch memrlimit-improve-error-handling-update.patch memrlimit-handle-attach_task-failure-add-can_attach-callback.patch memrlimit-handle-attach_task-failure-add-can_attach-callback-update.patch cpusets-restructure-the-function-update_cpumask-and-update_nodemask-fix.patch cpusets-update-tasks-cpus_allowed-and-mems_allowed-after-cpu-node-offline-online.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html