The patch titled
usb: debug port converter does not accept more than 8 byte packets
has been added to the -mm tree. Its filename is
usb-debug-port-converter-does-not-accept-more-than-8-byte-packets.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: usb: debug port converter does not accept more than 8 byte packets
From: Aleksey Gorelov <dared1st@xxxxxxxxx>
USB debug port only supports 8 byte rx/tx packets. Although spec implies
that "if a packet larger than eight bytes is received from the remote
computer, the device must break the larger packet into eight-byte packets
before sending the data to the Debug Port", the real PLX NET20DC device
does not handle it right - data is corrupted on debug port end if serial
interface sends >8 byte urbs.
The patch fixes the issue by limiting the tx urb to 8 byte.
Signed-off-by: Aleks Gorelov <dared1st@xxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/usb/serial/usb_debug.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff -puN drivers/usb/serial/usb_debug.c~usb-debug-port-converter-does-not-accept-more-than-8-byte-packets drivers/usb/serial/usb_debug.c
--- a/drivers/usb/serial/usb_debug.c~usb-debug-port-converter-does-not-accept-more-than-8-byte-packets
+++ a/drivers/usb/serial/usb_debug.c
@@ -15,6 +15,8 @@
#include <linux/usb.h>
#include <linux/usb/serial.h>
+#define USB_DEBUG_MAX_PACKET_SIZE 8
+
static struct usb_device_id id_table [] = {
{ USB_DEVICE(0x0525, 0x127a) },
{ },
@@ -29,6 +31,12 @@ static struct usb_driver debug_driver =
.no_dynamic_id = 1,
};
+int usb_debug_open (struct usb_serial_port *port, struct file *filp)
+{
+ port->bulk_out_size = USB_DEBUG_MAX_PACKET_SIZE;
+ return usb_serial_generic_open(port, filp);
+}
+
static struct usb_serial_driver debug_device = {
.driver = {
.owner = THIS_MODULE,
@@ -36,6 +44,7 @@ static struct usb_serial_driver debug_de
},
.id_table = id_table,
.num_ports = 1,
+ .open = usb_debug_open,
};
static int __init debug_init(void)
_
Patches currently in -mm which might be from dared1st@xxxxxxxxx are
usb-debug-port-converter-does-not-accept-more-than-8-byte-packets.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
