The patch titled
coredump: turn core_state->nr_threads into atomic_t
has been added to the -mm tree. Its filename is
coredump-turn-core_state-nr_threads-into-atomic_t.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: coredump: turn core_state->nr_threads into atomic_t
From: Oleg Nesterov <oleg@xxxxxxxxxx>
Turn core_state->nr_threads into atomic_t and kill now unneeded
down_write(&mm->mmap_sem) in exit_mm().
Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Cc: Roland McGrath <roland@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/exec.c | 2 +-
include/linux/mm_types.h | 2 +-
kernel/exit.c | 5 ++---
3 files changed, 4 insertions(+), 5 deletions(-)
diff -puN fs/exec.c~coredump-turn-core_state-nr_threads-into-atomic_t fs/exec.c
--- a/fs/exec.c~coredump-turn-core_state-nr_threads-into-atomic_t
+++ a/fs/exec.c
@@ -1592,7 +1592,7 @@ static inline int zap_threads(struct tas
}
rcu_read_unlock();
done:
- core_state->nr_threads = nr;
+ atomic_set(&core_state->nr_threads, nr);
mm->core_state = core_state;
return nr;
}
diff -puN include/linux/mm_types.h~coredump-turn-core_state-nr_threads-into-atomic_t include/linux/mm_types.h
--- a/include/linux/mm_types.h~coredump-turn-core_state-nr_threads-into-atomic_t
+++ a/include/linux/mm_types.h
@@ -160,7 +160,7 @@ struct vm_area_struct {
};
struct core_state {
- int nr_threads;
+ atomic_t nr_threads;
struct completion startup;
};
diff -puN kernel/exit.c~coredump-turn-core_state-nr_threads-into-atomic_t kernel/exit.c
--- a/kernel/exit.c~coredump-turn-core_state-nr_threads-into-atomic_t
+++ a/kernel/exit.c
@@ -670,10 +670,9 @@ static void exit_mm(struct task_struct *
down_read(&mm->mmap_sem);
if (mm->core_state) {
up_read(&mm->mmap_sem);
- down_write(&mm->mmap_sem);
- if (!--mm->core_state->nr_threads)
+
+ if (atomic_dec_and_test(&mm->core_state->nr_threads))
complete(&mm->core_state->startup);
- up_write(&mm->mmap_sem);
wait_for_completion(&mm->core_done);
down_read(&mm->mmap_sem);
_
Patches currently in -mm which might be from oleg@xxxxxxxxxx are
get_user_pages-fix-possible-page-leak-on-oom.patch
posix-timers-timer_delete-remove-the-bogus-it_process-=-null-check.patch
posix-timers-release_posix_timer-kill-the-bogus-put_task_struct-it_process.patch
signals-collect_signal-remove-the-unneeded-sigismember-check.patch
signals-collect_signal-simplify-the-still_pending-logic.patch
signals-change-collect_signal-to-return-void.patch
__exit_signal-dont-take-rcu-lock.patch
signals-dequeue_signal-dont-check-signal_group_exit-when-setting-signal_stop_dequeued.patch
signals-do_signal_stop-kill-the-signal_unkillable-check.patch
coredump-zap_threads-comments-use-while_each_thread.patch
signals-make-siginfo_t-si_utime-si_sstime-report-times-in-user_hz-not-hz.patch
kernel-signalc-change-vars-pid-and-tgid-types-to-pid_t.patch
include-asm-ptraceh-userspace-headers-cleanup.patch
ptrace-give-more-respect-to-sigkill.patch
ptrace-never-sleep-in-task_traced-if-sigkilled.patch
ptrace-kill-may_ptrace_stop.patch
introduce-pf_kthread-flag.patch
kill-pf_borrowed_mm-in-favour-of-pf_kthread.patch
coredump-zap_threads-must-skip-kernel-threads.patch
coredump-elf_core_dump-skip-kernel-threads.patch
coredump-turn-mm-core_startup_done-into-the-pointer-to-struct-core_state.patch
coredump-move-mm-core_waiters-into-struct-core_state.patch
coredump-simplify-core_state-nr_threads-calculation.patch
coredump-turn-core_state-nr_threads-into-atomic_t.patch
pidns-remove-now-unused-kill_proc-function.patch
pidns-remove-now-unused-find_pid-function.patch
pidns-remove-find_task_by_pid-unused-for-a-long-time.patch
distinct-tgid-tid-i-o-statistics.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
