The patch titled ext4: add missing unlock to an error path in ext4_quota_write() has been added to the -mm tree. Its filename is ext4-add-missing-unlock-to-an-error-path-in-ext4_quota_write.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ext4: add missing unlock to an error path in ext4_quota_write() From: Jan Kara <jack@xxxxxxx> When write in ext4_quota_write() fails, we have to properly release i_mutex. One error path has been missing the unlock... Signed-off-by: Jan Kara <jack@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ext4/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -puN fs/ext4/super.c~ext4-add-missing-unlock-to-an-error-path-in-ext4_quota_write fs/ext4/super.c --- a/fs/ext4/super.c~ext4-add-missing-unlock-to-an-error-path-in-ext4_quota_write +++ a/fs/ext4/super.c @@ -3337,8 +3337,10 @@ static ssize_t ext4_quota_write(struct s blk++; } out: - if (len == towrite) + if (len == towrite) { + mutex_unlock(&inode->i_mutex); return err; + } if (inode->i_size < off+len-towrite) { i_size_write(inode, off+len-towrite); EXT4_I(inode)->i_disksize = inode->i_size; _ Patches currently in -mm which might be from jack@xxxxxxx are ext3-add-missing-unlock-to-error-path-in-ext3_quota_write.patch ext4-add-missing-unlock-to-an-error-path-in-ext4_quota_write.patch ext3-fix-synchronization-of-quota-files-in-journal=data-mode.patch ext3-fix-typos-in-messages-and-comments-journalled-journaled.patch ext3-correct-mount-option-parsing-to-detect-when-quota-options-can-be-changed.patch jbd-fix-race-between-free-buffer-and-commit-trasanction.patch jbd-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes.patch jbd-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes-fix.patch ext3-validate-directory-entry-data-before-use.patch jbd-positively-dispose-the-unmapped-data-buffers-in-journal_commit_transaction.patch reiserfs-fix-synchronization-of-quota-files-in-journal=data-mode.patch reiserfs-fix-typos-in-messages-and-comments-journalled-journaled.patch reiserfs-correct-mount-option-parsing-to-detect-when-quota-options-can-be-changed.patch quota-rename-quota-functions-from-upper-case-make-bigger-ones-non-inline.patch quota-cleanup-loop-in-sync_dquots.patch quota-move-function-macros-from-quotah-to-quotaopsh.patch quota-move-function-macros-from-quotah-to-quotaopsh-jfs-fix.patch quota-move-function-macros-from-quotah-to-quotaopsh-jfs-fix-fix.patch quota-move-function-macros-from-quotah-to-quotaopsh-fix.patch quota-convert-macros-to-inline-functions.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html