The patch titled jbd2-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes has been removed from the -mm tree. Its filename was jbd2-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes.patch This patch was dropped because an updated version will be merged The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: jbd2-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> WARNING: line over 80 characters #34: FILE: fs/jbd2/transaction.c:1660: + * jbd2_journal_try_to_free_buffers() could race with jbd2_journal_commit_transaction() ERROR: code indent should use tabs where possible #93: FILE: fs/jbd2/transaction.c:1759: + ^I/*$ ERROR: code indent should use tabs where possible #108: FILE: fs/jbd2/transaction.c:1774: + ^Ispin_lock(&journal->j_state_lock);$ total: 2 errors, 1 warnings, 85 lines checked ./patches/jbd2-fix-race-between-free-buffer-and-commit-trasanction.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jan Kara <jack@xxxxxxx> Cc: Mingming Cao <cmm@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/jbd2/transaction.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN fs/jbd2/transaction.c~jbd2-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes fs/jbd2/transaction.c --- a/fs/jbd2/transaction.c~jbd2-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes +++ a/fs/jbd2/transaction.c @@ -1657,9 +1657,9 @@ out: } /* - * jbd2_journal_try_to_free_buffers() could race with jbd2_journal_commit_transaction() - * The later might still hold the reference count to the buffers when inspecting - * them on t_syncdata_list or t_locked_list. + * jbd2_journal_try_to_free_buffers() could race with + * jbd2_journal_commit_transaction(). The latter might still hold a reference + * on the buffers when inspecting them on t_syncdata_list or t_locked_list. * * jbd2_journal_try_to_free_buffers() will call this function to * wait for the current transaction to finish syncing data buffers, before @@ -1756,7 +1756,7 @@ int jbd2_journal_try_to_free_buffers(jou ret = try_to_free_buffers(page); - /* + /* * There are a number of places where jbd2_journal_try_to_free_buffers() * could race with jbd2_journal_commit_transaction(), the later still * holds the reference to the buffers to free while processing them. @@ -1771,7 +1771,7 @@ int jbd2_journal_try_to_free_buffers(jou * with the journal locked. */ if (ret == 0 && (gfp_mask & __GFP_WAIT) && (gfp_mask & __GFP_FS)) { - spin_lock(&journal->j_state_lock); + spin_lock(&journal->j_state_lock); jbd2_journal_wait_for_transaction_sync_data(journal); ret = try_to_free_buffers(page); spin_unlock(&journal->j_state_lock); _ Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are linux-next.patch next-remove-localversion.patch fix-kobject-fix-kobject_rename-and-config_sysfs.patch fix-driver-core-add-device_create_vargs-and-device_create_drvdata.patch kvm-is-busted-on-ia64.patch acpi-enable-c3-power-state-on-dell-inspiron-8200.patch acpi-video-balcklist-fujitsu-lifebook-s6410.patch git-x86-fixup.patch lguest-use-cpu-capability-accessors.patch arch-x86-mm-patc-nopat-should-be-__init.patch suspend-vs-iommu-prevent-suspend-if-we-could-not-resume-cleanup.patch arm-omap1-n770-convert-audio_pwr_sem-in-a-mutex.patch arch-powerpc-platforms-pseries-eeh_driverc-fix-warning.patch arch-powerpc-platforms-pseries-eeh_driverc-fix-warning-checkpatch-fixes.patch zoran-use-correct-type-for-cpu-flags.patch i2c-renesas-highlander-fpga-smbus-support.patch git-jg-misc-git-rejects.patch drivers-scsi-broadsasc-fix-uninitialised-var-warning.patch documentation-build-source-files-in-documentation-sub-dir-disable.patch fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver.patch mmc-sd-host-driver-for-ricoh-bay1controllers.patch git-ubifs.patch sundance-set-carrier-status-on-link-change-events.patch update-smc91x-driver-with-arm-versatile-board-info.patch git-battery.patch svcrdma-fix-compile-warning-on-32-bit-platforms-checkpatch-fixes.patch pci-hotplug-introduce-pci_slot.patch pci-hotplug-acpi-pci-slot-detection-driver.patch sched-delete-dead-stuff.patch sched-delete-dead-stuff-2.patch git-scsi-misc-fix-scsi_dh-build-errors.patch drivers-scsi-qla2xxx-qla_osc-suppress-uninitialized-var-warning.patch s390-uninline-spinlock-functions-which-use-smp_processor_id.patch pktcdvd-push-bkl-down-into-driver-fix.patch git-unionfs.patch git-unionfs-fixup.patch git-logfs-fixup.patch drivers-uwb-nehc-processor-flags-have-type-unsigned-long.patch drivers-usb-host-isp1760-hcdc-procesxor-flags-have-type-unsigned-long.patch drivers-uwb-wlp-sysfsc-dead-code.patch drivers-uwb-whcic-needs-dma-mappingh.patch usb-host-use-get-put_unaligned_-helpers-to-fix-more-potential-unaligned-issues-fix.patch usb-host-use-get-put_unaligned_-helpers-to-fix-more-potential-unaligned-issues-fix-2.patch git-watchdog.patch git-watchdog-git-rejects.patch watchdog-pcwd-clean-up-unlocked_ioctl-usage-fix.patch watchdog-wdt501-pci-clean-up-coding-style-and-switch-to-unlocked_ioctl-fix.patch git-xtensa.patch ext4-is-busted-on-m68k.patch capabilities-remain-source-compatible-with-32-bit-raw-legacy-capability-support.patch scsi-dpt_i2o-is-bust-on-ia64.patch libata-sff-fix-oops-reported-in-kerneloopsorg-for-pnp-devices-with-no-ctl-fix.patch mm-verify-the-page-links-and-memory-model.patch mspec-convert-nopfn-to-fault-fix.patch page-allocator-inlnie-some-__alloc_pages-wrappers-fix.patch kill-generic_file_direct_io-checkpatch-fixes.patch use-generic_access_phys-for-dev-mem-mappings-fix.patch spufs-use-the-new-vm_ops-access-fix.patch fix-soft-lock-up-at-nfs-mount-by-per-sb-lru-list-of-unused-dentries-fix.patch mapping_set_error-add-unlikely.patch vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch vm-dont-run-touch_buffer-during-buffercache-lookups.patch security-protect-legacy-apps-from-insufficient-privilege-cleanup.patch pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2-checkpatch-fixes.patch pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2-checkpatch-fixes-cleanup.patch pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2-checkpatch-fixes-cleanup-fix.patch swsusp-provide-users-with-a-hint-about-the-no_console_suspend-option-fix.patch split-the-typecheck-macros-out-of-include-linux-kernelh.patch locking-add-typecheck-on-irqsave-and-friends-for-correct-flags.patch locking-add-typecheck-on-irqsave-and-friends-for-correct-flags-fix.patch remove-apparently-unused-fd1772h-header-file.patch lib-allow-memparse-to-accept-a-null-and-ignorable-second-parm-checkpatch-fixes.patch build-kernel-profileo-only-when-requested-cleanups.patch rename-warn-to-warning-to-clear-the-namespace-fix.patch add-a-warn-macro-this-is-warn_on-printk-arguments-fix.patch flag-parameters-paccept-fix.patch flag-parameters-paccept-sys_ni.patch flag-parameters-anon_inode_getfd-extension-fix.patch flag-parameters-signalfd-fix.patch flag-parameters-eventfd-fix.patch flag-parameters-inotify_init-fix.patch flag-parameters-check-magic-constants-alpha.patch drivers-video-aty-radeon_basec-notify-user-if-sysfs_create_bin_file-failed-checkpatch-fixes.patch jbd-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes.patch jbd-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes-fix.patch reiserfs-convert-j_flush_sem-to-mutex.patch reiserfs-convert-j_commit_lock-to-mutex-checkpatch-fixes.patch jbd2-fix-race-between-free-buffer-and-commit-trasanction-checkpatch-fixes.patch dma-mapping-add-the-device-argument-to-dma_mapping_error-sge-fix.patch dma-mapping-add-the-device-argument-to-dma_mapping_error-svc_rdma-fix.patch dma-mapping-add-the-device-argument-to-dma_mapping_error-bnx2x.patch dma-mapping-add-the-device-argument-to-dma_mapping_error-sparc32.patch dma-mapping-x86-per-device-dma_mapping_ops-support-fix.patch ppc-use-the-common-ascii-hex-helpers-fix.patch reiser4.patch reiser4-semaphore-fix.patch page-owner-tracking-leak-detector.patch nr_blockdev_pages-in_interrupt-warning.patch slab-leaks3-default-y.patch put_bh-debug.patch shrink_slab-handle-bad-shrinkers.patch getblk-handle-2tb-devices.patch getblk-handle-2tb-devices-fix.patch undeprecate-pci_find_device.patch notify_change-callers-must-hold-i_mutex.patch profile-likely-unlikely-macros.patch drivers-net-bonding-bond_sysfsc-suppress-uninitialized-var-warning.patch w1-build-fix.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html