The patch titled netfilter: conntrack_helper needs to include rculist.h has been added to the -mm tree. Its filename is netfilter-conntrack_helper-needs-to-include-rculisth.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: netfilter: conntrack_helper needs to include rculist.h From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> nf_conntrack_helper users rcu hlist functions so it needs to #include rculist.h. linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu' filter/nf_conntrack_helper.o] Error 1 Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> Cc: Ingo Molnar <mingo@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- net/netfilter/nf_conntrack_helper.c | 1 + 1 file changed, 1 insertion(+) diff -puN net/netfilter/nf_conntrack_helper.c~netfilter-conntrack_helper-needs-to-include-rculisth net/netfilter/nf_conntrack_helper.c --- a/net/netfilter/nf_conntrack_helper.c~netfilter-conntrack_helper-needs-to-include-rculisth +++ a/net/netfilter/nf_conntrack_helper.c @@ -10,6 +10,7 @@ */ #include <linux/types.h> +#include <linux/rculist.h> #include <linux/netfilter.h> #include <linux/module.h> #include <linux/skbuff.h> _ Patches currently in -mm which might be from randy.dunlap@xxxxxxxxxx are origin.patch linux-next.patch documentation-build-source-files-in-documentation-sub-dir.patch 8390-split-8390-support-into-a-pausing-and-a-non-pausing-driver-core.patch 3c515-fix-using-pnp_get_resource-when-config_isapnp=n.patch e1000e-make-e1000e-default-to-the-same-kconfig-setting-as-e1000.patch netfilter-conntrack_helper-needs-to-include-rculisth.patch git-unionfs.patch uwb-fix-kconfig-causing-undefined-references.patch whci-allow-modular-fix-busted-build.patch audit-fix-kernel-doc-parameter-notation.patch scsi-do-not-automatically-select-scsi_dh-for-dm-multipath.patch flag-parameters-signalfd-fix.patch flag-parameters-eventfd-fix.patch bsdacct-stir-up-comments-around-acct_process.patch profile-likely-unlikely-macros.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html