The patch titled asic3: remove children platform data has been added to the -mm tree. Its filename is asic3-remove-children-platform-data.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: asic3: remove children platform data From: Samuel Ortiz <sameo@xxxxxxxxxxxxxx> Platform devices should be dynamically allocated, and each supported device should have its own platform data. For now we just remove this buggy code. Signed-off-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxx> Cc: David Brownell <david-b@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/mfd/asic3.c | 8 -------- include/linux/mfd/asic3.h | 3 --- 2 files changed, 11 deletions(-) diff -puN drivers/mfd/asic3.c~asic3-remove-children-platform-data drivers/mfd/asic3.c --- a/drivers/mfd/asic3.c~asic3-remove-children-platform-data +++ a/drivers/mfd/asic3.c @@ -607,14 +607,6 @@ static int asic3_probe(struct platform_d goto out_irq; } - if (pdata->children) { - int i; - for (i = 0; i < pdata->n_children; i++) { - pdata->children[i]->dev.parent = &pdev->dev; - platform_device_register(pdata->children[i]); - } - } - printk(KERN_INFO "ASIC3 Core driver\n"); return 0; diff -puN include/linux/mfd/asic3.h~asic3-remove-children-platform-data include/linux/mfd/asic3.h --- a/include/linux/mfd/asic3.h~asic3-remove-children-platform-data +++ a/include/linux/mfd/asic3.h @@ -32,9 +32,6 @@ struct asic3_platform_data { unsigned int irq_base; unsigned int gpio_base; - - struct platform_device **children; - unsigned int n_children; }; #define ASIC3_NUM_GPIO_BANKS 4 _ Patches currently in -mm which might be from sameo@xxxxxxxxxxxxxx are asic3-platform_get_irq-may-return-signed-unnoticed.patch asic3-gpiolib-support.patch asic3-remove-children-platform-data.patch asic3-new-gpio-configuration-code.patch asic3-use-dev_-macros.patch asic3-use-uppercase-only-for-macros-and-defines.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html