The patch titled
kexec: make extended crashkernel= syntax less confusing
has been added to the -mm tree. Its filename is
kexec-make-extended-crashkernel=-syntax-less-confusing.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: kexec: make extended crashkernel= syntax less confusing
From: Michael Ellerman <michael@xxxxxxxxxxxxxx>
The extended crashkernel syntax is a little confusing in the way it handles
ranges. eg:
crashkernel=512M-2G:64M,2G-:128M
Means if the machine has between 512M and 2G of memory the crash region should
be 64M, and if the machine has 2G of memory the region should be 64M. Only if
the machine has more than 2G memory will 128M be allocated.
Although that semantic is correct, it is somewhat baffling. Instead I propose
that the end of the range means the first address past the end of the range,
ie: 512M up to but not including 2G.
Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>
Acked-by: Bernhard Walle <bwalle@xxxxxxx>
Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/kexec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN kernel/kexec.c~kexec-make-extended-crashkernel=-syntax-less-confusing kernel/kexec.c
--- a/kernel/kexec.c~kexec-make-extended-crashkernel=-syntax-less-confusing
+++ a/kernel/kexec.c
@@ -1217,7 +1217,7 @@ static int __init parse_crashkernel_mem(
}
/* match ? */
- if (system_ram >= start && system_ram <= end) {
+ if (system_ram >= start && system_ram < end) {
*crash_size = size;
break;
}
_
Patches currently in -mm which might be from michael@xxxxxxxxxxxxxx are
origin.patch
kexec-make-extended-crashkernel=-syntax-less-confusing.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
