The patch titled uml: make three functions static has been added to the -mm tree. Its filename is uml-make-three-functions-static.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: uml: make three functions static From: WANG Cong <xiyou.wangcong@xxxxxxxxx> Make the following three functions static, since they don't need to be global. arch/um/drivers/mcast_kern.c::mcast_setup() arch/um/drivers/mconsole_user.c::mconsole_reply_v0() arch/um/drivers/port_user.c::port_pre_exec() Acked-by: Jeff Dike <jdike@xxxxxxxxxxx> Signed-off-by: WANG Cong <wangcong@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/um/drivers/mcast_kern.c | 2 +- arch/um/drivers/mconsole_user.c | 2 +- arch/um/drivers/port_user.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff -puN arch/um/drivers/mcast_kern.c~uml-make-three-functions-static arch/um/drivers/mcast_kern.c --- a/arch/um/drivers/mcast_kern.c~uml-make-three-functions-static +++ a/arch/um/drivers/mcast_kern.c @@ -58,7 +58,7 @@ static const struct net_kern_info mcast_ .write = mcast_write, }; -int mcast_setup(char *str, char **mac_out, void *data) +static int mcast_setup(char *str, char **mac_out, void *data) { struct mcast_init *init = data; char *port_str = NULL, *ttl_str = NULL, *remain; diff -puN arch/um/drivers/mconsole_user.c~uml-make-three-functions-static arch/um/drivers/mconsole_user.c --- a/arch/um/drivers/mconsole_user.c~uml-make-three-functions-static +++ a/arch/um/drivers/mconsole_user.c @@ -39,7 +39,7 @@ static struct mconsole_command commands[ /* Initialized in mconsole_init, which is an initcall */ char mconsole_socket_name[256]; -int mconsole_reply_v0(struct mc_request *req, char *reply) +static int mconsole_reply_v0(struct mc_request *req, char *reply) { struct iovec iov; struct msghdr msg; diff -puN arch/um/drivers/port_user.c~uml-make-three-functions-static arch/um/drivers/port_user.c --- a/arch/um/drivers/port_user.c~uml-make-three-functions-static +++ a/arch/um/drivers/port_user.c @@ -153,7 +153,7 @@ struct port_pre_exec_data { int pipe_fd; }; -void port_pre_exec(void *arg) +static void port_pre_exec(void *arg) { struct port_pre_exec_data *data = arg; _ Patches currently in -mm which might be from xiyou.wangcong@xxxxxxxxx are uml-compile-error-fix.patch git-hrt.patch arch-um-kernel-um_archc-some-small-improvements.patch arch-um-os-linux-start_upc-various-improvements.patch uml-make-a-function-static.patch uml-remove-a-useless-function.patch uml-make-three-functions-static.patch uml-make-several-things-static.patch uml-clean-up-arch-um-drivers-ubd_kernc.patch remove-the-macro-get_personality.patch elf-fix-shadowed-variables-in-fs-binfmt_elfc.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html