The patch titled
mtd/chips: add missing set_current_state() to cfi_{amdstd,staa}_sync()
has been added to the -mm tree. Its filename is
mtd-chips-add-missing-set_current_state-to-cfi_amdstdstaa_sync.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mtd/chips: add missing set_current_state() to cfi_{amdstd,staa}_sync()
From: Dmitry Adamushko <dmitry.adamushko@xxxxxxxxx>
cfi_amdstd_sync() and cfi_staa_sync() call schedule() without changing task's
state appropriately.
In case of e.g. chip->state == FL_ERASING, cfi_*_sync() will be busy-looping
either redundantly for a fixed interval of time (for SCHED_NORMAL tasks) or
possibly endlessly (for RT tasks and UP).
Signed-off-by: Dmitry Adamushko <dmitry.adamushko@xxxxxxxxx>
Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/mtd/chips/cfi_cmdset_0002.c | 1 +
drivers/mtd/chips/cfi_cmdset_0020.c | 1 +
2 files changed, 2 insertions(+)
diff -puN drivers/mtd/chips/cfi_cmdset_0002.c~mtd-chips-add-missing-set_current_state-to-cfi_amdstdstaa_sync drivers/mtd/chips/cfi_cmdset_0002.c
--- a/drivers/mtd/chips/cfi_cmdset_0002.c~mtd-chips-add-missing-set_current_state-to-cfi_amdstdstaa_sync
+++ a/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1763,6 +1763,7 @@ static void cfi_amdstd_sync (struct mtd_
default:
/* Not an idle state */
+ set_current_state(TASK_UNINTERRUPTIBLE);
add_wait_queue(&chip->wq, &wait);
spin_unlock(chip->mutex);
diff -puN drivers/mtd/chips/cfi_cmdset_0020.c~mtd-chips-add-missing-set_current_state-to-cfi_amdstdstaa_sync drivers/mtd/chips/cfi_cmdset_0020.c
--- a/drivers/mtd/chips/cfi_cmdset_0020.c~mtd-chips-add-missing-set_current_state-to-cfi_amdstdstaa_sync
+++ a/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -1015,6 +1015,7 @@ static void cfi_staa_sync (struct mtd_in
default:
/* Not an idle state */
+ set_current_state(TASK_UNINTERRUPTIBLE);
add_wait_queue(&chip->wq, &wait);
spin_unlock_bh(chip->mutex);
_
Patches currently in -mm which might be from dmitry.adamushko@xxxxxxxxx are
git-sched.patch
kthread-call-wake_up_process-without-the-lock-being-held.patch
mtd-chips-add-missing-set_current_state-to-cfi_amdstdstaa_sync.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
