+ watchdog-it8712f_wdt-zero-msb-timeout-byte-when-disabling-watchdog.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     watchdog: it8712f_wdt: zero MSB timeout byte when disabling watchdog
has been added to the -mm tree.  Its filename is
     watchdog-it8712f_wdt-zero-msb-timeout-byte-when-disabling-watchdog.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: watchdog: it8712f_wdt: zero MSB timeout byte when disabling watchdog
From: "Andrew Paprocki" <andrew@xxxxxxxxxxx>

I noticed this while testing the latest code.  I'm not sure if it is required,
but the normal (or LSB) timeout value is set to zero, so the MSB should be as
well to stay consistent.

If the chip revision is >= 8, set MSB of the 16-bit timeout value to zero when
disabling the watchdog in it8712f_wdt_disable().

Signed-off-by: Andrew Paprocki <andrew@xxxxxxxxxxx>
Cc: Wim Van Sebroeck <wim@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/watchdog/it8712f_wdt.c |    2 ++
 1 file changed, 2 insertions(+)

diff -puN drivers/watchdog/it8712f_wdt.c~watchdog-it8712f_wdt-zero-msb-timeout-byte-when-disabling-watchdog drivers/watchdog/it8712f_wdt.c
--- a/drivers/watchdog/it8712f_wdt.c~watchdog-it8712f_wdt-zero-msb-timeout-byte-when-disabling-watchdog
+++ a/drivers/watchdog/it8712f_wdt.c
@@ -210,6 +210,8 @@ it8712f_wdt_disable(void)
 
 	superio_outb(0, WDT_CONFIG);
 	superio_outb(0, WDT_CONTROL);
+	if (revision >= 0x08)
+		superio_outb(0, WDT_TIMEOUT + 1);
 	superio_outb(0, WDT_TIMEOUT);
 
 	superio_exit();
_

Patches currently in -mm which might be from andrew@xxxxxxxxxxx are

git-watchdog.patch
watchdog-it8712f_wdt-zero-msb-timeout-byte-when-disabling-watchdog.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux