The patch titled Fix misuse of wakeup flag accessors in serial core has been added to the -mm tree. Its filename is fix-misuse-of-wakeup-flag-accessors-in-serial-core.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: Fix misuse of wakeup flag accessors in serial core From: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> This patch (as1059) fixes a mistake in the way the serial core initializes a device's wakeup settings. It should use the accessor routine instead of relying on a macro producing an lvalue. Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx> Cc: Greg KH <greg@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/serial/serial_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/serial/serial_core.c~fix-misuse-of-wakeup-flag-accessors-in-serial-core drivers/serial/serial_core.c --- a/drivers/serial/serial_core.c~fix-misuse-of-wakeup-flag-accessors-in-serial-core +++ a/drivers/serial/serial_core.c @@ -2422,7 +2422,7 @@ int uart_add_one_port(struct uart_driver */ tty_dev = tty_register_device(drv->tty_driver, port->line, port->dev); if (likely(!IS_ERR(tty_dev))) { - device_can_wakeup(tty_dev) = 1; + device_init_wakeup(tty_dev, 1); device_set_wakeup_enable(tty_dev, 0); } else printk(KERN_ERR "Cannot register tty device on line %d\n", _ Patches currently in -mm which might be from stern@xxxxxxxxxxxxxxxxxxx are revert-gregkh-driver-pm-make-wakeup-flags-available-whenever-config_pm-is-set.patch fix-misuse-of-wakeup-flag-accessors-in-serial-core.patch pm-make-wakeup-flags-available-whenever-config_pm-is-set-ver-2.patch pm-convert-wakeup-flag-accessors-to-inline-functions.patch isd200-fix-memory-leak-in-isd200_get_inquiry_data.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html