The patch titled modules: make module_sect_attrs private to kernel/module.c has been added to the -mm tree. Its filename is make-module_sect_attrs-private-to-kernel-modulec.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: modules: make module_sect_attrs private to kernel/module.c From: "Jan Beulich" <jbeulich@xxxxxxxxxx> No-one else is using these afaics. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/module.h | 17 ----------------- kernel/module.c | 16 +++++++++++++++- 2 files changed, 15 insertions(+), 18 deletions(-) diff -puN include/linux/module.h~make-module_sect_attrs-private-to-kernel-modulec include/linux/module.h --- a/include/linux/module.h~make-module_sect_attrs-private-to-kernel-modulec +++ a/include/linux/module.h @@ -229,23 +229,6 @@ enum module_state MODULE_STATE_GOING, }; -/* Similar stuff for section attributes. */ -struct module_sect_attr -{ - struct module_attribute mattr; - char *name; - unsigned long address; -}; - -struct module_sect_attrs -{ - struct attribute_group grp; - int nsections; - struct module_sect_attr attrs[0]; -}; - -struct module_param_attrs; - struct module { enum module_state state; diff -puN kernel/module.c~make-module_sect_attrs-private-to-kernel-modulec kernel/module.c --- a/kernel/module.c~make-module_sect_attrs-private-to-kernel-modulec +++ a/kernel/module.c @@ -991,6 +991,20 @@ static unsigned long resolve_symbol(Elf_ * J. Corbet <corbet@xxxxxxx> */ #if defined(CONFIG_KALLSYMS) && defined(CONFIG_SYSFS) +struct module_sect_attr +{ + struct module_attribute mattr; + char *name; + unsigned long address; +}; + +struct module_sect_attrs +{ + struct attribute_group grp; + unsigned int nsections; + struct module_sect_attr attrs[0]; +}; + static ssize_t module_sect_show(struct module_attribute *mattr, struct module *mod, char *buf) { @@ -1001,7 +1015,7 @@ static ssize_t module_sect_show(struct m static void free_sect_attrs(struct module_sect_attrs *sect_attrs) { - int section; + unsigned int section; for (section = 0; section < sect_attrs->nsections; section++) kfree(sect_attrs->attrs[section].name); _ Patches currently in -mm which might be from jbeulich@xxxxxxxxxx are lib-swiotlbc-avoid-endless-loops-fix.patch git-x86.patch lib-swiotlbc-cleanups.patch reduce-module-image-and-resident-size.patch make-module_sect_attrs-private-to-kernel-modulec.patch fix-verify_export_symbols.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html