The patch titled
leds: call gpio_cansleep only after gpio_request succeeded
has been added to the -mm tree. Its filename is
leds-call-gpio_cansleep-only-after-gpio_request-succeeded.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: leds: call gpio_cansleep only after gpio_request succeeded
From: Uwe Kleine-Koeni <Uwe.Kleine-Koenig@xxxxxxxx>
If you have GPIO_LIB gpio_cansleep oopses on an invalid gpio. So better
gpio_request your pin first.
Signed-off-by: Uwe Kleine-Koeni <Uwe.Kleine-Koenig@xxxxxxxx>
Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Cc: Raphael Assenat <raph@xxxxxx>
Cc: Richard Purdie <rpurdie@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/leds/leds-gpio.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff -puN drivers/leds/leds-gpio.c~leds-call-gpio_cansleep-only-after-gpio_request-succeeded drivers/leds/leds-gpio.c
--- a/drivers/leds/leds-gpio.c~leds-call-gpio_cansleep-only-after-gpio_request-succeeded
+++ a/drivers/leds/leds-gpio.c
@@ -79,6 +79,10 @@ static int gpio_led_probe(struct platfor
cur_led = &pdata->leds[i];
led_dat = &leds_data[i];
+ ret = gpio_request(cur_led->gpio, cur_led->name);
+ if (ret < 0)
+ goto err;
+
led_dat->cdev.name = cur_led->name;
led_dat->cdev.default_trigger = cur_led->default_trigger;
led_dat->gpio = cur_led->gpio;
@@ -87,10 +91,6 @@ static int gpio_led_probe(struct platfor
led_dat->cdev.brightness_set = gpio_led_set;
led_dat->cdev.brightness = LED_OFF;
- ret = gpio_request(led_dat->gpio, led_dat->cdev.name);
- if (ret < 0)
- goto err;
-
gpio_direction_output(led_dat->gpio, led_dat->active_low);
INIT_WORK(&led_dat->work, gpio_led_work);
_
Patches currently in -mm which might be from Uwe.Kleine-Koenig@xxxxxxxx are
leds-call-gpio_cansleep-only-after-gpio_request-succeeded.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
