The patch titled
tun/tap: fix RTNL-locking
has been removed from the -mm tree. Its filename was
tun-tap-fix-rtnl-locking.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: tun/tap: fix RTNL-locking
From: "Kim B. Heino" <Kim.Heino@xxxxxxxxxxxx>
Current tun/tap driver sets also net device's hw address when asked to change
character device's hw address. This is a good idea, but it misses
RTLN-locking, resulting following error message in 2.6.25-rc3's
inetdev_event() function:
RTNL: assertion failed at net/ipv4/devinet.c (1050)
Signed-off-by: Kim B. Heino <Kim.Heino@xxxxxxxxxxxx>
Cc: Maxim Krasnyansky <maxk@xxxxxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/net/tun.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff -puN drivers/net/tun.c~tun-tap-fix-rtnl-locking drivers/net/tun.c
--- a/drivers/net/tun.c~tun-tap-fix-rtnl-locking
+++ a/drivers/net/tun.c
@@ -663,7 +663,11 @@ static int tun_chr_ioctl(struct inode *i
case SIOCSIFHWADDR:
{
/* try to set the actual net device's hw address */
- int ret = dev_set_mac_address(tun->dev, &ifr.ifr_hwaddr);
+ int ret;
+
+ rtnl_lock();
+ ret = dev_set_mac_address(tun->dev, &ifr.ifr_hwaddr);
+ rtnl_unlock();
if (ret == 0) {
/** Set the character device's hardware address. This is used when
_
Patches currently in -mm which might be from Kim.Heino@xxxxxxxxxxxx are
git-net.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
