The patch titled
markers: don't risk NULL deref in marker
has been added to the -mm tree. Its filename is
markers-dont-risk-null-deref-in-marker.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: markers: don't risk NULL deref in marker
From: Jesper Juhl <jesper.juhl@xxxxxxxxx>
get_marker() may return NULL, so test for it.
Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/marker.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff -puN kernel/marker.c~markers-dont-risk-null-deref-in-marker kernel/marker.c
--- a/kernel/marker.c~markers-dont-risk-null-deref-in-marker
+++ a/kernel/marker.c
@@ -698,12 +698,11 @@ int marker_probe_unregister(const char *
{
struct marker_entry *entry;
struct marker_probe_closure *old;
- int ret = 0;
+ int ret = -ENOENT;
mutex_lock(&markers_mutex);
entry = get_marker(name);
if (!entry) {
- ret = -ENOENT;
goto end;
}
if (entry->rcu_pending)
@@ -713,12 +712,16 @@ int marker_probe_unregister(const char *
marker_update_probes(); /* may update entry */
mutex_lock(&markers_mutex);
entry = get_marker(name);
+ if (!entry) {
+ goto end;
+ }
entry->oldptr = old;
entry->rcu_pending = 1;
/* write rcu_pending before calling the RCU callback */
smp_wmb();
call_rcu(&entry->rcu, free_old_closure);
remove_marker(name); /* Ignore busy error message */
+ ret = 0;
end:
mutex_unlock(&markers_mutex);
return ret;
_
Patches currently in -mm which might be from jesper.juhl@xxxxxxxxx are
markers-dont-risk-null-deref-in-marker.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
