The patch titled
cgroup: fix sparse warning of shadow symbol in cgroup.c
has been added to the -mm tree. Its filename is
cgroup-fix-sparse-warning-of-shadow-symbol-in-cgroupc.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: cgroup: fix sparse warning of shadow symbol in cgroup.c
From: Paul Jackson <pj@xxxxxxx>
Fix a code warning: symbol 'p' shadows an earlier one
This is a reincarnation of Harvey Harrison's patch:
cpuset: sparse warnings in cpuset.c
Independently, Cliff Wickman moved the affected code,
from kernel/cpuset.c to kernel/cgroup.c, in his patch:
cpusets: update_cpumask revision
Signed-off-by: Paul Jackson <pj@xxxxxxx>
Cc: Harvey Harrison <harvey.harrison@xxxxxxxxx>
Cc: Cliff Wickman <cpw@xxxxxxx>
Acked-by: Paul Menage <menage@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/cgroup.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff -puN kernel/cgroup.c~cgroup-fix-sparse-warning-of-shadow-symbol-in-cgroupc kernel/cgroup.c
--- a/kernel/cgroup.c~cgroup-fix-sparse-warning-of-shadow-symbol-in-cgroupc
+++ a/kernel/cgroup.c
@@ -1900,14 +1900,14 @@ int cgroup_scan_tasks(struct cgroup_scan
if (heap->size) {
for (i = 0; i < heap->size; i++) {
- struct task_struct *p = heap->ptrs[i];
+ struct task_struct *q = heap->ptrs[i];
if (i == 0) {
- latest_time = p->start_time;
- latest_task = p;
+ latest_time = q->start_time;
+ latest_task = q;
}
/* Process the task per the caller's callback */
- scan->process_task(p, scan);
- put_task_struct(p);
+ scan->process_task(q, scan);
+ put_task_struct(q);
}
/*
* If we had to process any tasks at all, scan again
_
Patches currently in -mm which might be from pj@xxxxxxx are
cpuset-trivial-documentation-fix-s-n_memory-n_high_memory.patch
cgroup-fix-sparse-warning-of-shadow-symbol-in-cgroupc.patch
kernel-cpusetc-make-3-functions-static.patch
documentation-patch-tags-one-more-time.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
