The patch titled s3fb: add option mode_option has been added to the -mm tree. Its filename is s3fb-add-option-mode_option.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: s3fb: add option mode_option From: Krzysztof Helt <krzysztof.h1@xxxxx> Add the option "mode_option". It also moves mtrr variable to devinitdata section. Signed-off-by: Krzysztof Helt <krzysztof.h1@xxxxx> Cc: "Antonino A. Daplas" <adaplas@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/video/s3fb.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff -puN drivers/video/s3fb.c~s3fb-add-option-mode_option drivers/video/s3fb.c --- a/drivers/video/s3fb.c~s3fb-add-option-mode_option +++ a/drivers/video/s3fb.c @@ -132,10 +132,10 @@ static const struct svga_timing_regs s3_ /* Module parameters */ -static char *mode = "640x480-8@60"; +static char *mode_option __devinitdata = "640x480-8@60"; #ifdef CONFIG_MTRR -static int mtrr = 1; +static int mtrr __devinitdata = 1; #endif static int fasttext = 1; @@ -145,8 +145,10 @@ MODULE_AUTHOR("(c) 2006-2007 Ondrej Zaji MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("fbdev driver for S3 Trio/Virge"); -module_param(mode, charp, 0444); -MODULE_PARM_DESC(mode, "Default video mode ('640x480-8@60', etc)"); +module_param(mode_option, charp, 0444); +MODULE_PARM_DESC(mode_option, "Default video mode ('640x480-8@60', etc)"); +module_param_named(mode, mode_option, charp, 0444); +MODULE_PARM_DESC(mode, "Default video mode ('640x480-8@60', etc) (deprecated)"); #ifdef CONFIG_MTRR module_param(mtrr, int, 0444); @@ -960,10 +962,10 @@ static int __devinit s3_pci_probe(struct info->pseudo_palette = (void*) (par->pseudo_palette); /* Prepare startup mode */ - rc = fb_find_mode(&(info->var), info, mode, NULL, 0, NULL, 8); + rc = fb_find_mode(&(info->var), info, mode_option, NULL, 0, NULL, 8); if (! ((rc == 1) || (rc == 2))) { rc = -EINVAL; - dev_err(&(dev->dev), "mode %s not found\n", mode); + dev_err(&(dev->dev), "mode %s not found\n", mode_option); goto err_find_mode; } @@ -1168,7 +1170,7 @@ static int __init s3fb_setup(char *opti else if (!strncmp(opt, "fasttext:", 9)) fasttext = simple_strtoul(opt + 9, NULL, 0); else - mode = opt; + mode_option = opt; } return 0; _ Patches currently in -mm which might be from krzysztof.h1@xxxxx are pm2fb-correct-error-values-returned-from-probe-function.patch pm2fb-change-option-mode-to-mode_option.patch tridentfb-change-option-mode-to-mode_option.patch pm3fb-change-option-mode-to-mode_option.patch update-modedbtxt-documentation-about-mode_option-parameter-change.patch vt8623fb-change-option-mode-to-mode_option.patch arkfb-add-option-mode_option.patch s3fb-add-option-mode_option.patch fbdev-add-removed-option-mode-to-keep-compatibility.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html