The patch titled r/o bind mounts: write counts for link/symlink has been added to the -mm tree. Its filename is r-o-bind-mounts-write-counts-for-link-symlink.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: r/o bind mounts: write counts for link/symlink From: Dave Hansen <haveblue@xxxxxxxxxx> Acked-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Signed-off-by: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Dave Hansen <haveblue@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/namei.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff -puN fs/namei.c~r-o-bind-mounts-write-counts-for-link-symlink fs/namei.c --- a/fs/namei.c~r-o-bind-mounts-write-counts-for-link-symlink +++ a/fs/namei.c @@ -2366,7 +2366,12 @@ asmlinkage long sys_symlinkat(const char if (IS_ERR(dentry)) goto out_unlock; + error = mnt_want_write(nd.path.mnt); + if (error) + goto out_dput; error = vfs_symlink(nd.path.dentry->d_inode, dentry, from, S_IALLUGO); + mnt_drop_write(nd.path.mnt); +out_dput: dput(dentry); out_unlock: mutex_unlock(&nd.path.dentry->d_inode->i_mutex); @@ -2461,7 +2466,12 @@ asmlinkage long sys_linkat(int olddfd, c error = PTR_ERR(new_dentry); if (IS_ERR(new_dentry)) goto out_unlock; + error = mnt_want_write(nd.path.mnt); + if (error) + goto out_dput; error = vfs_link(old_nd.path.dentry, nd.path.dentry->d_inode, new_dentry); + mnt_drop_write(nd.path.mnt); +out_dput: dput(new_dentry); out_unlock: mutex_unlock(&nd.path.dentry->d_inode->i_mutex); _ Patches currently in -mm which might be from haveblue@xxxxxxxxxx are enable-hotplug-memory-remove-for-ppc64.patch reiserfs-eliminate-private-use-of-struct-file-in-xattr.patch hppfs-pass-vfsmount-to-dentry_open.patch check-for-null-vfsmount-in-dentry_open.patch fix-up-new-filp-allocators.patch do-namei_flags-calculation-inside-open_namei.patch merge-open_namei-and-do_filp_open.patch r-o-bind-mounts-stub-functions.patch r-o-bind-mounts-create-helper-to-drop-file-write-access.patch r-o-bind-mounts-drop-write-during-emergency-remount.patch r-o-bind-mounts-elevate-write-count-for-vfs_rmdir.patch r-o-bind-mounts-elevate-write-count-for-callers-of-vfs_mkdir.patch r-o-bind-mounts-elevate-mnt_writers-for-unlink-callers.patch r-o-bind-mounts-elevate-write-count-for-xattr_permission-callers.patch r-o-bind-mounts-elevate-write-count-for-ncp_ioctl.patch r-o-bind-mounts-write-counts-for-time-functions.patch r-o-bind-mounts-elevate-write-count-for-do_utimes.patch r-o-bind-mounts-write-count-for-file_update_time.patch r-o-bind-mounts-write-counts-for-link-symlink.patch r-o-bind-mounts-elevate-write-count-for-ioctls.patch r-o-bind-mounts-elevate-write-count-for-opens.patch r-o-bind-mounts-get-write-access-for-vfs_rename-callers.patch r-o-bind-mounts-elevate-write-count-for-chmod-chown-callers.patch r-o-bind-mounts-write-counts-for-truncate.patch r-o-bind-mounts-elevate-count-for-xfs-timestamp-updates.patch r-o-bind-mounts-make-access-use-new-r-o-helper.patch r-o-bind-mounts-check-mnt-instead-of-superblock-directly.patch r-o-bind-mounts-get-callers-of-vfs_mknod-create.patch r-o-bind-mounts-track-numbers-of-writers-to-mounts.patch r-o-bind-mounts-honor-mount-writer-counts-at-remount.patch r-o-bind-mounts-debugging-for-missed-calls.patch reiser4.patch page-owner-tracking-leak-detector.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html