The patch titled
NFSD: fix wrong mnt_writer count in rename
has been removed from the -mm tree. Its filename was
use-struct-path-in-struct-svc_export-nfsd-fix-wrong-mnt_writer-count-in-rename.patch
This patch was dropped because it was folded into use-struct-path-in-struct-svc_export.patch
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: NFSD: fix wrong mnt_writer count in rename
From: Erez Zadok <ezk@xxxxxxxxxxxxx>
NFSD forgets to call mnt_drop_write after a successful rename. Here's a
fix. (Ah, the curse of a stackable file system developer: you have to
debug everyone else's too. :-)
One thing I wasn't sure is whether I could move the mnt_drop_write line a
little above, just after the call to vfs_rename. If we can drop the ref
earlier, it could improve scalability/performance just a bit, no? (i.e.,
what are the ramifications of holding on to this mnt writer ref longer than
needed?)
Signed-off-by: Erez Zadok <ezk@xxxxxxxxxxxxx>
Cc: Dave Hansen <haveblue@xxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/nfsd/vfs.c | 1 +
1 file changed, 1 insertion(+)
diff -puN fs/nfsd/vfs.c~use-struct-path-in-struct-svc_export-nfsd-fix-wrong-mnt_writer-count-in-rename fs/nfsd/vfs.c
--- a/fs/nfsd/vfs.c~use-struct-path-in-struct-svc_export-nfsd-fix-wrong-mnt_writer-count-in-rename
+++ a/fs/nfsd/vfs.c
@@ -1702,6 +1702,7 @@ nfsd_rename(struct svc_rqst *rqstp, stru
if (!host_err)
host_err = nfsd_sync_dir(fdentry);
}
+ mnt_drop_write(ffhp->fh_export->ex_path.mnt);
out_dput_new:
dput(ndentry);
_
Patches currently in -mm which might be from ezk@xxxxxxxxxxxxx are
git-unionfs.patch
iget-stop-unionfs-from-using-iget-and-read_inode.patch
use-struct-path-in-struct-svc_export.patch
use-struct-path-in-struct-svc_export-nfsd-fix-wrong-mnt_writer-count-in-rename.patch
embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-vs-git-unionfs.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
