The patch titled ext2: convert byte order of constant instead of variable has been added to the -mm tree. Its filename is ext2-convert-byte-order-of-constant-instead-of-variable.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ext2: convert byte order of constant instead of variable From: Marcin Slusarz <marcin.slusarz@xxxxxxxxx> Convert byte order of constant instead of variable which can be done at compile time (vs run time). Signed-off-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx> Cc: <linux-ext4@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ext2/super.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff -puN fs/ext2/super.c~ext2-convert-byte-order-of-constant-instead-of-variable fs/ext2/super.c --- a/fs/ext2/super.c~ext2-convert-byte-order-of-constant-instead-of-variable +++ a/fs/ext2/super.c @@ -51,8 +51,7 @@ void ext2_error (struct super_block * sb if (!(sb->s_flags & MS_RDONLY)) { sbi->s_mount_state |= EXT2_ERROR_FS; - es->s_state = - cpu_to_le16(le16_to_cpu(es->s_state) | EXT2_ERROR_FS); + es->s_state |= cpu_to_le16(EXT2_ERROR_FS); ext2_sync_super(sb, es); } @@ -1126,10 +1125,9 @@ void ext2_write_super (struct super_bloc if (!(sb->s_flags & MS_RDONLY)) { es = EXT2_SB(sb)->s_es; - if (le16_to_cpu(es->s_state) & EXT2_VALID_FS) { + if (es->s_state & cpu_to_le16(EXT2_VALID_FS)) { ext2_debug ("setting valid to 0\n"); - es->s_state = cpu_to_le16(le16_to_cpu(es->s_state) & - ~EXT2_VALID_FS); + es->s_state &= cpu_to_le16(~EXT2_VALID_FS); es->s_free_blocks_count = cpu_to_le32(ext2_count_free_blocks(sb)); es->s_free_inodes_count = cpu_to_le32(ext2_count_free_inodes(sb)); es->s_mtime = cpu_to_le32(get_seconds()); _ Patches currently in -mm which might be from marcin.slusarz@xxxxxxxxx are xfs-convert-bex_add-to-bex_add_cpu-new-common-api.patch udf-fix-directory-offset-handling.patch udf-fix-udf_add_free_space.patch git-gfs2-nmw.patch jfs-le_add_cpu-conversion.patch ntfs-le_add_cpu-conversion.patch ocfs2-le_add_cpu-conversion.patch scsi-le_add_cpu-conversion.patch ipw2200-le_add_cpu-conversion.patch ext2-le_add_cpu-conversion.patch ufs-e_add_cpu-conversion.patch ufs-e_add_cpu-conversion-in-return.patch reiserfs-le_add_cpu-conversion.patch ext4-le_add_cpu-conversion.patch affs-be_add_cpu-conversion.patch hfs-hfsplus-be_add_cpu-conversion.patch quota-le_add_cpu-conversion.patch sysv-e_add_cpu-conversion.patch ext2-convert-byte-order-of-constant-instead-of-variable.patch ext3-convert-byte-order-of-constant-instead-of-variable.patch ext4-convert-byte-order-of-constant-instead-of-variable.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html