The patch titled
ipmi: change device node ordering to reflect probe order
has been added to the -mm tree. Its filename is
ipmi-change-device-node-ordering-to-reflect-probe-order.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: ipmi: change device node ordering to reflect probe order
From: Carol Hebert <cah@xxxxxxxxxx>
Currently, on systems with multiple BMC interfaces, the ipmi device names are
being created in reverse order relative to how they are discovered on the
system (e.g. on an IBM x3950 multinode server with N nodes, the device name
for the BMC in the first node is /dev/ipmiN-1 and the device name for the BMC
in the last node is /dev/ipmi0, etc.). The problem is caused by the list
handling routines chosen in dmi_scan.c. Using list_add() causes the multiple
ipmi devices to be added to the device list using a stack-paradigm and so the
ipmi driver subsequently pulls them off during initialization in LIFO order.
This patch changes the dmi_save_ipmi_device() list handling paradigm to a
queue, thereby allowing the ipmi driver to build the ipmi device names in the
order in which they are found on the system.
Signed-off-by: Carol Hebert <cah@xxxxxxxxxx>
Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/firmware/dmi_scan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/firmware/dmi_scan.c~ipmi-change-device-node-ordering-to-reflect-probe-order drivers/firmware/dmi_scan.c
--- a/drivers/firmware/dmi_scan.c~ipmi-change-device-node-ordering-to-reflect-probe-order
+++ a/drivers/firmware/dmi_scan.c
@@ -272,7 +272,7 @@ static void __init dmi_save_ipmi_device(
dev->name = "IPMI controller";
dev->device_data = data;
- list_add(&dev->list, &dmi_devices);
+ list_add_tail(&dev->list, &dmi_devices);
}
static void __init dmi_save_extended_devices(const struct dmi_header *dm)
_
Patches currently in -mm which might be from cah@xxxxxxxxxx are
ipmi-change-device-node-ordering-to-reflect-probe-order.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
