The patch titled 2.6.24-mm1 Build Faliure on pgtable_32.c has been added to the -mm tree. Its filename is add-mm-argument-to-pte-pmd-pud-pgd_free-fix.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: 2.6.24-mm1 Build Faliure on pgtable_32.c From: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> Hi Andrew, The 2.6.24-mm1 kernel build fails with arch/x86/mm/pgtable_32.c: In function `pgd_mop_up_pmds': arch/x86/mm/pgtable_32.c:302: warning: passing arg 1 of `pmd_free' from incompatible pointer type arch/x86/mm/pgtable_32.c:302: error: too few arguments to function `pmd_free' I have tested the patch for the build failure only. Signed-off-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/x86/mm/pgtable_32.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN arch/x86/mm/pgtable_32.c~add-mm-argument-to-pte-pmd-pud-pgd_free-fix arch/x86/mm/pgtable_32.c --- a/arch/x86/mm/pgtable_32.c~add-mm-argument-to-pte-pmd-pud-pgd_free-fix +++ a/arch/x86/mm/pgtable_32.c @@ -286,7 +286,7 @@ static void pgd_dtor(void *pgd) * preallocate which never got a corresponding vma will need to be * freed manually. */ -static void pgd_mop_up_pmds(pgd_t *pgdp) +static void pgd_mop_up_pmds(struct mm_struct *mm, pgd_t *pgdp) { int i; @@ -299,7 +299,7 @@ static void pgd_mop_up_pmds(pgd_t *pgdp) pgdp[i] = native_make_pgd(0); paravirt_release_pd(pgd_val(pgd) >> PAGE_SHIFT); - pmd_free(pmd); + pmd_free(mm, pmd); } } } @@ -327,7 +327,7 @@ static int pgd_prepopulate_pmd(struct mm pmd_t *pmd = pmd_alloc_one(mm, addr); if (!pmd) { - pgd_mop_up_pmds(pgd); + pgd_mop_up_pmds(mm, pgd); return 0; } @@ -347,7 +347,7 @@ static int pgd_prepopulate_pmd(struct mm return 1; } -static void pgd_mop_up_pmds(pgd_t *pgd) +static void pgd_mop_up_pmds(struct mm_struct *mm, pgd_t *pgdp) { } #endif /* CONFIG_X86_PAE */ @@ -368,7 +368,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm) void pgd_free(struct mm_struct *mm, pgd_t *pgd) { - pgd_mop_up_pmds(pgd); + pgd_mop_up_pmds(mm,pgd); quicklist_free(0, pgd_dtor, pgd); } _ Patches currently in -mm which might be from kamalesh@xxxxxxxxxxxxxxxxxx are origin.patch add-mm-argument-to-pte-pmd-pud-pgd_free-fix.patch scsi-fix-isa-pcmcia-compile-problem.patch inotify-send-in_attrib-events-when-link-count-changes-fix.patch iget-stop-bfs-from-using-iget-and-read_inode-try-fix.patch proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-fix-2.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html