The patch titled
rtc: update documentation wrt irq_set_freq
has been added to the -mm tree. Its filename is
rtc-update-documentation-wrt-irq_set_freq.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: rtc: update documentation wrt irq_set_freq
From: Mike Frysinger <vapier.adi@xxxxxxxxx>
Document the proper use of the irq_set_freq function.
Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
Cc: David Brownell <david-b@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
Documentation/rtc.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN Documentation/rtc.txt~rtc-update-documentation-wrt-irq_set_freq Documentation/rtc.txt
--- a/Documentation/rtc.txt~rtc-update-documentation-wrt-irq_set_freq
+++ a/Documentation/rtc.txt
@@ -182,8 +182,8 @@ driver returns ENOIOCTLCMD. Some common
since the frequency is stored in the irq_freq member of the rtc_device
structure. Your driver needs to initialize the irq_freq member during
init. Make sure you check the requested frequency is in range of your
- hardware in the irq_set_freq function. If you cannot actually change
- the frequency, just return -ENOTTY.
+ hardware in the irq_set_freq function. If it isn't, return -EINVAL. If
+ you cannot actually change the frequency, do not define irq_set_freq.
If all else fails, check out the rtc-test.c driver!
_
Patches currently in -mm which might be from vapier.adi@xxxxxxxxx are
git-kbuild.patch
git-watchdog.patch
kernel-printkc-concerns-about-the-console-handover.patch
remove-inclusions-of-linux-autoconfh.patch
rtc-update-documentation-wrt-irq_set_freq.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
