The patch titled aoe: add module parameter for users who need more outstanding I/O has been added to the -mm tree. Its filename is aoe-add-module-parameter-for-users-who-need-more-outstanding-i-o.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: aoe: add module parameter for users who need more outstanding I/O From: "Ed L. Cashin" <ecashin@xxxxxxxxxx> An AoE target provides an estimate of the number of outstanding commands that the AoE initiator can send before getting a response. The aoe_maxout parameter provides a way to set an even lower limit. It will not allow a user to use more outstanding commands than the target permits. If a user discovers a problem with a large setting, this parameter provides a way for us to work with them to debug the problem. We expect to improve the dynamic window sizing algorithm and drop this parameter. For the time being, it is a debugging aid. Signed-off-by: Ed L. Cashin <ecashin@xxxxxxxxxx> Cc: Greg KH <greg@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/block/aoe/aoecmd.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff -puN drivers/block/aoe/aoecmd.c~aoe-add-module-parameter-for-users-who-need-more-outstanding-i-o drivers/block/aoe/aoecmd.c --- a/drivers/block/aoe/aoecmd.c~aoe-add-module-parameter-for-users-who-need-more-outstanding-i-o +++ a/drivers/block/aoe/aoecmd.c @@ -18,6 +18,11 @@ static int aoe_deadsecs = 60 * 3; module_param(aoe_deadsecs, int, 0644); MODULE_PARM_DESC(aoe_deadsecs, "After aoe_deadsecs seconds, give up and fail dev."); +static int aoe_maxout = 16; +module_param(aoe_maxout, int, 0644); +MODULE_PARM_DESC(aoe_maxout, + "Only aoe_maxout outstanding packets for every MAC on eX.Y."); + static struct sk_buff * new_skb(ulong len) { @@ -984,7 +989,6 @@ aoecmd_cfg_rsp(struct sk_buff *skb) struct aoeif *ifp; ulong flags, sysminor, aoemajor; struct sk_buff *sl; - enum { MAXFRAMES = 16 }; u16 n; h = (struct aoe_hdr *) skb_mac_header(skb); @@ -1009,8 +1013,8 @@ aoecmd_cfg_rsp(struct sk_buff *skb) } n = be16_to_cpu(ch->bufcnt); - if (n > MAXFRAMES) /* keep it reasonable */ - n = MAXFRAMES; + if (n > aoe_maxout) /* keep it reasonable */ + n = aoe_maxout; d = aoedev_by_sysminor_m(sysminor); if (d == NULL) { _ Patches currently in -mm which might be from ecashin@xxxxxxxxxx are aoe-bring-driver-version-number-to-47.patch aoe-handle-multiple-network-paths-to-aoe-device.patch aoe-mac_addr-avoid-64-bit-arch-compiler-warnings.patch aoe-clean-up-udev-configuration-example.patch aoe-eliminate-goto-and-improve-readability.patch aoe-user-can-ask-driver-to-forget-previously-detected-devices.patch aoe-dynamically-allocate-a-capped-number-of-skbs-when-necessary.patch aoe-only-install-new-aoe-device-once.patch aoe-add-module-parameter-for-users-who-need-more-outstanding-i-o.patch aoe-the-aoeminor-doesnt-need-a-long-format.patch aoe-make-error-messages-more-specific.patch aoe-update-copyright-date.patch aoe-statically-initialise-devlist_lock.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html