The patch titled ecryptfs: fix string overflow on long cipher names has been added to the -mm tree. Its filename is ecryptfs-fix-string-overflow-on-long-cipher-names.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: ecryptfs: fix string overflow on long cipher names From: Eric Sandeen <sandeen@xxxxxxxxxx> Passing a cipher name > 32 chars on mount results in an overflow when the cipher name is printed, because the last character in the struct ecryptfs_key_tfm's cipher_name string was never zeroed. Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Acked-by: Michael Halcrow <mhalcrow@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ecryptfs/crypto.c | 1 + 1 file changed, 1 insertion(+) diff -puN fs/ecryptfs/crypto.c~ecryptfs-fix-string-overflow-on-long-cipher-names fs/ecryptfs/crypto.c --- a/fs/ecryptfs/crypto.c~ecryptfs-fix-string-overflow-on-long-cipher-names +++ a/fs/ecryptfs/crypto.c @@ -1847,6 +1847,7 @@ ecryptfs_add_new_key_tfm(struct ecryptfs mutex_init(&tmp_tfm->key_tfm_mutex); strncpy(tmp_tfm->cipher_name, cipher_name, ECRYPTFS_MAX_CIPHER_NAME_SIZE); + tmp_tfm->cipher_name[ECRYPTFS_MAX_CIPHER_NAME_SIZE] = '\0'; tmp_tfm->key_size = key_size; rc = ecryptfs_process_key_cipher(&tmp_tfm->key_tfm, tmp_tfm->cipher_name, _ Patches currently in -mm which might be from sandeen@xxxxxxxxxx are ecryptfs-initialize-new-auth_tokens-before-teardown.patch ecryptfs-set-s_blocksize-from-lower-fs-in-sb.patch ecryptfs-fix-fsx-data-corruption-problems.patch ecryptfs-fix-string-overflow-on-long-cipher-names.patch ext2-change-the-default-behaviour-on-error.patch ecryptfs-make-show_options-reflect-actual-mount-options.patch ecryptfs-make-show_options-reflect-actual-mount-options-fix.patch ext4-fix-mb_debug-format-warnings.patch ext4-fix-freespace-accounting-with-mballoc-on-32bit-machines.patch ext4-fix-oops-with-jbd-stats-through-procfs-and-external.patch ext4-fix-up-ext4fs_debug-builds.patch ext3-change-the-default-behaviour-on-error.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html