The patch titled arch/powerpc: add missing of_node_put has been added to the -mm tree. Its filename is arch-powerpc-add-missing-of_node_put.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: arch/powerpc: add missing of_node_put From: Julia Lawall <julia@xxxxxxx> There should be an of_node_put when breaking out of a loop that iterates over calls to of_find_all_nodes, as this function does an of_node_get on the value it returns. This was fixed using the following semantic patch. (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ type T; identifier d; expression e; @@ T *d; ... for (d = NULL; (d = of_find_all_nodes(d)) != NULL; ) {... when != of_node_put(d) when != e = d ( return d; | + of_node_put(d); ? return ...; ) ...} // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Cc: Paul Mackerras <paulus@xxxxxxxxx> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/powerpc/platforms/iseries/iommu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -puN arch/powerpc/platforms/iseries/iommu.c~arch-powerpc-add-missing-of_node_put arch/powerpc/platforms/iseries/iommu.c --- a/arch/powerpc/platforms/iseries/iommu.c~arch-powerpc-add-missing-of_node_put +++ a/arch/powerpc/platforms/iseries/iommu.c @@ -163,8 +163,10 @@ static struct iommu_table *iommu_table_f (it->it_type == TCE_PCI) && (it->it_offset == tbl->it_offset) && (it->it_index == tbl->it_index) && - (it->it_size == tbl->it_size)) + (it->it_size == tbl->it_size)) { + of_node_put(node); return it; + } } return NULL; } _ Patches currently in -mm which might be from julia@xxxxxxx are origin.patch git-alsa.patch drivers-char-remove-unnecessary-pci_dev_put.patch arch-ppc-remove-an-unnecessary-pci_dev_put.patch arch-powerpc-add-missing-of_node_put.patch git-input.patch drivers-video-remove-unnecessary-pci_dev_put.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html