The patch titled
NFSD: fix wrong mnt_writer count in rename
has been added to the -mm tree. Its filename is
use-struct-path-in-struct-svc_export-nfsd-fix-wrong-mnt_writer-count-in-rename.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: NFSD: fix wrong mnt_writer count in rename
From: Erez Zadok <ezk@xxxxxxxxxxxxx>
NFSD forgets to call mnt_drop_write after a successful rename. Here's a
fix. (Ah, the curse of a stackable file system developer: you have to
debug everyone else's too. :-)
One thing I wasn't sure is whether I could move the mnt_drop_write line a
little above, just after the call to vfs_rename. If we can drop the ref
earlier, it could improve scalability/performance just a bit, no? (i.e.,
what are the ramifications of holding on to this mnt writer ref longer than
needed?)
Signed-off-by: Erez Zadok <ezk@xxxxxxxxxxxxx>
Cc: Dave Hansen <haveblue@xxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/nfsd/vfs.c | 1 +
1 file changed, 1 insertion(+)
diff -puN fs/nfsd/vfs.c~use-struct-path-in-struct-svc_export-nfsd-fix-wrong-mnt_writer-count-in-rename fs/nfsd/vfs.c
--- a/fs/nfsd/vfs.c~use-struct-path-in-struct-svc_export-nfsd-fix-wrong-mnt_writer-count-in-rename
+++ a/fs/nfsd/vfs.c
@@ -1693,6 +1693,7 @@ nfsd_rename(struct svc_rqst *rqstp, stru
if (!host_err)
host_err = nfsd_sync_dir(fdentry);
}
+ mnt_drop_write(ffhp->fh_export->ex_path.mnt);
out_dput_new:
dput(ndentry);
_
Patches currently in -mm which might be from ezk@xxxxxxxxxxxxx are
origin.patch
git-unionfs.patch
vfs-apply-coding-standards-to-fs-ioctlc.patch
vfs-swap-do_ioctl-and-vfs_ioctl-names.patch
vfs-swap-do_ioctl-and-vfs_ioctl-names-fix.patch
vfs-factor-out-three-helpers-for-fibmap-fionbio-fioasync-file-ioctls.patch
x86-early_quirks-cleanup.patch
add-64-bit-capability-support-to-the-kernel-fix-fix.patch
read_current_time-cleanups-build-fix.patch
read_current_time-cleanups-build-fix-fix.patch
r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch
r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop-checkpatch-fixes.patch
create-file_drop_write_access-helper.patch
fix-up-new-filp-allocators.patch
iget-stop-unionfs-from-using-iget-and-read_inode.patch
iget-stop-unionfs-from-using-iget-and-read_inode-fix.patch
use-struct-path-in-struct-svc_export-nfsd-fix-wrong-mnt_writer-count-in-rename.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
