The patch titled fix gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse has been added to the -mm tree. Its filename is fix-gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: fix gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse From: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> The build fails, with the build error drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: Ë?struct kobjet declared inside parameter list drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: its scope is only this definition or declaration, which is probably not what you want drivers/pci/hotplug/rpadlpar_sysfs.c:59: warning: Ë?struct kobjet declared inside parameter list drivers/pci/hotplug/rpadlpar_sysfs.c: In function Ë?remove_slot_store: drivers/pci/hotplug/rpadlpar_sysfs.c:79: error: expected Ë?; before Ë?return drivers/pci/hotplug/rpadlpar_sysfs.c: At top level: drivers/pci/hotplug/rpadlpar_sysfs.c:89: warning: initialization from incompatible pointer type drivers/pci/hotplug/rpadlpar_sysfs.c:92: warning: initialization from incompatible pointer type drivers/pci/hotplug/rpadlpar_sysfs.c: In function Ë?remove_slot_store: drivers/pci/hotplug/rpadlpar_sysfs.c:80: warning: control reaches end of non-void function make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1 make[2]: *** [drivers/pci/hotplug] Error 2 make[1]: *** [drivers/pci] Error 2 make: *** [drivers] Error 2 This is caused by the patch gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse.patch. Signed-off-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> Cc: Greg KH <greg@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/pci/hotplug/rpadlpar_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/pci/hotplug/rpadlpar_sysfs.c~fix-gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse drivers/pci/hotplug/rpadlpar_sysfs.c --- a/drivers/pci/hotplug/rpadlpar_sysfs.c~fix-gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse +++ a/drivers/pci/hotplug/rpadlpar_sysfs.c @@ -54,7 +54,7 @@ static ssize_t add_slot_show(struct kobj return sprintf(buf, "0\n"); } -static ssize_t remove_slot_store(struct kobjet *kobj, +static ssize_t remove_slot_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t nbytes) { @@ -74,7 +74,7 @@ static ssize_t remove_slot_store(struct rc = dlpar_remove_slot(drc_name); if (rc) - return rc + return rc; return nbytes; } _ Patches currently in -mm which might be from kamalesh@xxxxxxxxxxxxxxxxxx are chipsfb-uses-depends-on-pci.patch export-acpi_check_resource_conflict.patch fix-gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse.patch config_highpte-vs-sub-page-page-tables-fix.patch add-dma-engine-driver-for-freescale-mpc85xx-processors-fix.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html