+ cfq-fix-ioprio_class_idle-accounting.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     cfq: fix IOPRIO_CLASS_IDLE accounting
has been added to the -mm tree.  Its filename is
     cfq-fix-ioprio_class_idle-accounting.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: cfq: fix IOPRIO_CLASS_IDLE accounting
From: Oleg Nesterov <oleg@xxxxxxxxxx>

Spotted by Nick <gentuu@xxxxxxxxx>, hopefully can explain the second trace
in http://bugzilla.kernel.org/show_bug.cgi?id=9180.

If ->async_idle_cfqq != NULL cfq_put_async_queues() puts it IOPRIO_BE_NR
times in a loop.  Fix this.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 block/cfq-iosched.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff -puN block/cfq-iosched.c~cfq-fix-ioprio_class_idle-accounting block/cfq-iosched.c
--- a/block/cfq-iosched.c~cfq-fix-ioprio_class_idle-accounting
+++ a/block/cfq-iosched.c
@@ -2068,9 +2068,10 @@ static void cfq_put_async_queues(struct 
 			cfq_put_queue(cfqd->async_cfqq[0][i]);
 		if (cfqd->async_cfqq[1][i])
 			cfq_put_queue(cfqd->async_cfqq[1][i]);
-		if (cfqd->async_idle_cfqq)
-			cfq_put_queue(cfqd->async_idle_cfqq);
 	}
+
+	if (cfqd->async_idle_cfqq)
+		cfq_put_queue(cfqd->async_idle_cfqq);
 }
 
 static void cfq_exit_queue(elevator_t *e)
_

Patches currently in -mm which might be from oleg@xxxxxxxxxx are

origin.patch
cfq-fix-ioprio_class_idle-accounting.patch
add-task_wakekill.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux