The patch titled
crash on shutdown/unmount
has been added to the -mm tree. Its filename is
crash-on-shutdown-unmount.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: crash on shutdown/unmount
From: Jens Axboe <jens.axboe@xxxxxxxxxx>
On Wed, Oct 31 2007, Alistair John Strachan wrote:
> Hi Jens,
>
> I guessed from the oops that you might have an idea what's causing this oops
> on shutdown/unmount. The git version (describe), a screenshot showing the
> oops, a config, and dmesg for a booted kernel are available from:
>
> http://devzero.co.uk/~alistair/oops-20071031/
>
> I went back to -rc1 and it still happens there too. If you need any more
> information or want me to bisect it, please let me know.
Does this work for you?
index 54fd385..75c98d5 100644
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
block/ll_rw_blk.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff -puN block/ll_rw_blk.c~crash-on-shutdown-unmount block/ll_rw_blk.c
--- a/block/ll_rw_blk.c~crash-on-shutdown-unmount
+++ a/block/ll_rw_blk.c
@@ -3221,6 +3221,7 @@ static inline void __generic_make_reques
sector_t old_sector;
int ret, nr_sectors = bio_sectors(bio);
dev_t old_dev;
+ int err = -EIO;
might_sleep();
@@ -3248,7 +3249,7 @@ static inline void __generic_make_reques
bdevname(bio->bi_bdev, b),
(long long) bio->bi_sector);
end_io:
- bio_endio(bio, -EIO);
+ bio_endio(bio, err);
break;
}
@@ -3283,6 +3284,10 @@ end_io:
if (bio_check_eod(bio, nr_sectors))
goto end_io;
+ if (bio_empty_barrier(bio) && !q->prepare_flush_fn) {
+ err = -EOPNOTSUPP;
+ goto end_io;
+ }
ret = q->make_request_fn(q, bio);
} while (ret);
_
Patches currently in -mm which might be from jens.axboe@xxxxxxxxxx are
origin.patch
scsi-early-detection-of-medium-not-present-updated.patch
git-block.patch
git-block-fixup.patch
crash-on-shutdown-unmount.patch
arch-um-drivers-ubd_kernc-a-warning-fix.patch
fix-versus-precedence-in-various-places.patch
fix-versus-precedence-in-various-places-checkpatch-fixes.patch
revoke-vs-git-block.patch
reiser4.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
