On Thu, 25 Oct 2007 15:41:04 +0200 Jean Delvare <khali@xxxxxxxxxxxx> wrote: > Hi Andrew, > > On Wed, 24 Oct 2007 20:51:33 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > > > The patch titled > > provide-acpi_check_mem_region-checkpatch-fixes > > has been added to the -mm tree. Its filename is > > provide-acpi_check_mem_region-checkpatch-fixes.patch > > > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > > > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find > > out what to do about this > > > > ------------------------------------------------------ > > Subject: provide-acpi_check_mem_region-checkpatch-fixes > > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > > WARNING: printk() should include KERN_ facility level > > #133: FILE: drivers/acpi/osl.c:1133: > > + printk("%sACPI: %s resource %s [0x%llx-0x%llx]" > > > > total: 0 errors, 1 warnings, 224 lines checked > > Your patch has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > > > Please run checkpatch prior to sending patches > > Except that checkpatch is wrong in this case, the original patch was > correct and your add-on broke it. The log level is %s because it > depends on the value of acpi_enforce_resources. > > I admit it's a bit tricky and I'm not surprised checkpatch got > confused. It's probably rare enough that it's not worth fixing the > script. OK. We now have KERN_CONT, which is the empty string. It could have been used here as a way of keeping checkpatch happy and to tell readers "yes, this printk's faciliy level has been thought about". KERN_CONT is also useful for things like ata_dev_printk() which _require_ a facility level. - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
