The patch titled introduce-flags-for-reserve_bootmem-checkpatch-fixes has been added to the -mm tree. Its filename is introduce-flags-for-reserve_bootmem-checkpatch-fixes.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: introduce-flags-for-reserve_bootmem-checkpatch-fixes From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> WARNING: line over 80 characters #872: FILE: arch/x86/kernel/setup_32.c:486: + reserve_bootmem(crash_base, crash_size, BOOTMEM_DEFAULT); WARNING: line over 80 characters #916: FILE: arch/x86/kernel/setup_32.c:562: + reserve_bootmem(ramdisk_image, ramdisk_size, BOOTMEM_DEFAULT); WARNING: line over 80 characters #1058: FILE: mm/bootmem.c:114: +static int __init reserve_bootmem_core(bootmem_data_t *bdata, unsigned long addr, total: 0 errors, 3 warnings, 833 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Bernhard Walle <bwalle@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/x86/kernel/setup_32.c | 6 ++++-- mm/bootmem.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff -puN arch/x86/kernel/setup_32.c~introduce-flags-for-reserve_bootmem-checkpatch-fixes arch/x86/kernel/setup_32.c --- a/arch/x86/kernel/setup_32.c~introduce-flags-for-reserve_bootmem-checkpatch-fixes +++ a/arch/x86/kernel/setup_32.c @@ -483,7 +483,8 @@ static void __init reserve_crashkernel(v (unsigned long)(total_mem >> 20)); crashk_res.start = crash_base; crashk_res.end = crash_base + crash_size - 1; - reserve_bootmem(crash_base, crash_size, BOOTMEM_DEFAULT); + reserve_bootmem(crash_base, crash_size, + BOOTMEM_DEFAULT); } else printk(KERN_INFO "crashkernel reservation failed - " "you have to specify a base address\n"); @@ -559,7 +560,8 @@ void __init setup_bootmem_allocator(void unsigned long end_of_lowmem = max_low_pfn << PAGE_SHIFT; if (ramdisk_end <= end_of_lowmem) { - reserve_bootmem(ramdisk_image, ramdisk_size, BOOTMEM_DEFAULT); + reserve_bootmem(ramdisk_image, ramdisk_size, + BOOTMEM_DEFAULT); initrd_start = ramdisk_image + PAGE_OFFSET; initrd_end = initrd_start+ramdisk_size; } else { diff -puN mm/bootmem.c~introduce-flags-for-reserve_bootmem-checkpatch-fixes mm/bootmem.c --- a/mm/bootmem.c~introduce-flags-for-reserve_bootmem-checkpatch-fixes +++ a/mm/bootmem.c @@ -111,8 +111,8 @@ static unsigned long __init init_bootmem * might be used for boot-time allocations - or it might get added * to the free page pool later on. */ -static int __init reserve_bootmem_core(bootmem_data_t *bdata, unsigned long addr, - unsigned long size, int flags) +static int __init reserve_bootmem_core(bootmem_data_t *bdata, + unsigned long addr, unsigned long size, int flags) { unsigned long sidx, eidx; unsigned long i; _ Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are sunrpc-fix-rpc-debugging-checkpatch-fixes.patch acpi-add-reboot-mechanism.patch provide-acpi_check_mem_region-checkpatch-fixes.patch git-alsa.patch working-3d-dri-intel-agpko-resume-for-i815-chip.patch revert-gregkh-driver-block-device.patch git-hwmon.patch ia64-slim-down-__clear_bit_unlock-checkpatch-fixes.patch first-stab-at-elantech-touchpad-driver-for-26226-testers.patch fix-appletouch-geyser-1-breakage-checkpatch-fixes.patch git-kvm.patch git-libata-all.patch drivers-ata-libata-ehc-fix-printk-warning.patch ata-ahci-enable-enclosure-management-via-led-checkpatch-fixes.patch ide-arm-hack.patch nf_ct_alloc_hashtable-use-__gfp_nowarn.patch ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes.patch update-smc91x-driver-with-arm-versatile-board-info.patch git-nfsd-fixup.patch fix-build-breakage-if-sysfs-fix.patch git-unionfs.patch git-v9fs-fixup.patch git-watchdog.patch watchdog-add-nano-7240-driver-checkpatch-fixes.patch git-wireless.patch git-wireless-fixup.patch jiffies_round-jiffies_round_relative-conversion-rt2x00-checkpatch-fixes.patch git-x86.patch git-x86-fixup.patch oprofile-op_model_athalonc-support-for-amd-family10h-barcelona-performance-counters-checkpatch-fixes.patch x86-fix-config_smp-warning-in-processorc-fix.patch i386-and-x86_64-randomize-brk-fix.patch i386-resolve-dependency-of-asm-i386-pgtableh-on-highmemh-checkpatch-fixes.patch slub-fix-coding-style-violations-checkpatch-fixes.patch bufferhead-revert-constructor-removal-checkpatch-fixes.patch vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch vm-dont-run-touch_buffer-during-buffercache-lookups.patch pm-qos-infrastructure-and-interface.patch pm-qos-infrastructure-and-interface-static-initialization-with-blocking-notifiers.patch deprecate-smbfs-in-favour-of-cifs.patch procfs-detect-duplicate-names.patch kernel-printkc-concerns-about-the-console-handover.patch fix-versus-precedence-in-various-places-checkpatch-fixes.patch pie-executable-randomization.patch pie-executable-randomization-checkpatch-fixes.patch riscom8-fix-smp-brokenness-fix.patch use-macros-instead-of-task_-flags-checkpatch-fixes.patch sync_sb_inodes-propagate-errors.patch peterz-vs-ext4-mballoc-core.patch 64-bit-i_version-afs-fixes.patch r-o-bind-mounts-elevate-write-count-during-entire-ncp_ioctl-fix.patch slab-api-remove-useless-ctor-parameter-and-reorder-parameters-vs-revoke.patch revoke-wire-up-i386-system-calls.patch revoke-vs-git-block.patch memory-controller-memory-accounting-v7.patch memory-controller-add-per-container-lru-and-reclaim-v7.patch memory-controller-oom-handling-v7.patch memory-controller-add-switch-to-control-what-type-of-pages-to-limit-v7.patch memcontrol-move-oom-task-exclusion-to-tasklist.patch drivers-edac-add-marvell-mv64x60-driver-fix.patch embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-checkpatch-fixes.patch introduce-flags-for-reserve_bootmem-checkpatch-fixes.patch make-copy_from_user_inatomic-not-zero-the-tail-on-i386-vs-reiser4.patch reiser4.patch page-owner-tracking-leak-detector.patch nr_blockdev_pages-in_interrupt-warning.patch slab-leaks3-default-y.patch profile-likely-unlikely-macros-fix.patch put_bh-debug.patch kmap_atomic-debugging.patch shrink_slab-handle-bad-shrinkers.patch getblk-handle-2tb-devices.patch w1-build-fix.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html