The patch titled
I/OAT: clean up of dca provider start and stop
has been added to the -mm tree. Its filename is
i-oat-clean-up-of-dca-provider-start-and-stop.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: I/OAT: clean up of dca provider start and stop
From: Shannon Nelson <shannon.nelson@xxxxxxxxx>
Don't start ioat_dca if ioat_dma didn't start, and then stop ioat_dca
before stopping ioat_dma. Since the ioat_dma side does the pci device
work, This takes care of ioat_dca trying to use a bad device reference.
Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/dma/ioat.c | 11 +++++------
drivers/dma/ioat_dma.c | 4 ++--
2 files changed, 7 insertions(+), 8 deletions(-)
diff -puN drivers/dma/ioat.c~i-oat-clean-up-of-dca-provider-start-and-stop drivers/dma/ioat.c
--- a/drivers/dma/ioat.c~i-oat-clean-up-of-dca-provider-start-and-stop
+++ a/drivers/dma/ioat.c
@@ -71,7 +71,7 @@ static int ioat_setup_functionality(stru
switch (version) {
case IOAT_VER_1_2:
device->dma = ioat_dma_probe(pdev, iobase);
- if (ioat_dca_enabled)
+ if (device->dma && ioat_dca_enabled)
device->dca = ioat_dca_init(pdev, iobase);
break;
default:
@@ -85,17 +85,16 @@ static void ioat_shutdown_functionality(
{
struct ioat_device *device = pci_get_drvdata(pdev);
- if (device->dma) {
- ioat_dma_remove(device->dma);
- device->dma = NULL;
- }
-
if (device->dca) {
unregister_dca_provider(device->dca);
free_dca_provider(device->dca);
device->dca = NULL;
}
+ if (device->dma) {
+ ioat_dma_remove(device->dma);
+ device->dma = NULL;
+ }
}
static struct pci_driver ioat_pci_driver = {
diff -puN drivers/dma/ioat_dma.c~i-oat-clean-up-of-dca-provider-start-and-stop drivers/dma/ioat_dma.c
--- a/drivers/dma/ioat_dma.c~i-oat-clean-up-of-dca-provider-start-and-stop
+++ a/drivers/dma/ioat_dma.c
@@ -941,10 +941,10 @@ void ioat_dma_remove(struct ioatdma_devi
struct dma_chan *chan, *_chan;
struct ioat_dma_chan *ioat_chan;
- dma_async_device_unregister(&device->common);
-
ioat_dma_remove_interrupts(device);
+ dma_async_device_unregister(&device->common);
+
pci_pool_destroy(device->dma_pool);
pci_pool_destroy(device->completion_pool);
_
Patches currently in -mm which might be from shannon.nelson@xxxxxxxxx are
origin.patch
remove-unsafe-from-module-struct.patch
i-oat-cleanup-pci-issues.patch
i-oat-clean-up-of-dca-provider-start-and-stop.patch
i-oat-clean-up-error-handling-and-some-print-messages.patch
i-oat-tighten-descriptor-setup-performance.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
