The patch titled
fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte-checkpatch-fixes
has been removed from the -mm tree. Its filename was
fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte-checkpatch-fixes.patch
This patch was dropped because it was folded into fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte.patch
------------------------------------------------------
Subject: fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte-checkpatch-fixes
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
ERROR: do not use C99 // comments
#30: FILE: drivers/video/cfbcopyarea.c:97:
+ // Different alignment for source and dest
ERROR: no space after that open parenthesis '('
#63: FILE: drivers/video/cfbcopyarea.c:124:
+ FB_WRITEL( comp(d0, FB_READL(dst), first), dst);
ERROR: no space after that open parenthesis '('
#92: FILE: drivers/video/cfbcopyarea.c:151:
+ FB_WRITEL( comp(d0, FB_READL(dst), first), dst);
WARNING: line over 80 characters
#125: FILE: drivers/video/cfbcopyarea.c:189:
+ d1 = fb_rev_pixels_in_long(d1, bswapmask);
ERROR: no space after that open parenthesis '('
#129: FILE: drivers/video/cfbcopyarea.c:193:
+ FB_WRITEL( comp(d0, FB_READL(dst), last), dst);
ERROR: no space after that open parenthesis '('
#165: FILE: drivers/video/cfbcopyarea.c:292:
+ FB_WRITEL( comp(d0, FB_READL(dst), first), dst);
ERROR: no space after that open parenthesis '('
#193: FILE: drivers/video/cfbcopyarea.c:315:
+ FB_WRITEL( comp(d0, FB_READL(dst), first), dst);
WARNING: line over 80 characters
#228: FILE: drivers/video/cfbcopyarea.c:355:
+ d1 = fb_rev_pixels_in_long(d1, bswapmask);
ERROR: no space after that open parenthesis '('
#232: FILE: drivers/video/cfbcopyarea.c:359:
+ FB_WRITEL( comp(d0, FB_READL(dst), last), dst);
ERROR: need a space before the open parenthesis '('
#256: FILE: drivers/video/fb_draw.h:88:
+ if(bswapmask & 1)
ERROR: need a space before the open parenthesis '('
#258: FILE: drivers/video/fb_draw.h:90:
+ if(bswapmask & 2)
ERROR: need a space before the open parenthesis '('
#260: FILE: drivers/video/fb_draw.h:92:
+ if(bswapmask & 3)
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Cc: Antonino Daplas <adaplas@xxxxxxxxx>
Cc: Pavel Pisa <pisa@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/video/cfbcopyarea.c | 20 +++++++++++---------
drivers/video/fb_draw.h | 6 +++---
2 files changed, 14 insertions(+), 12 deletions(-)
diff -puN drivers/video/cfbcopyarea.c~fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte-checkpatch-fixes drivers/video/cfbcopyarea.c
--- a/drivers/video/cfbcopyarea.c~fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte-checkpatch-fixes
+++ a/drivers/video/cfbcopyarea.c
@@ -94,7 +94,7 @@ bitcpy(unsigned long __iomem *dst, int d
FB_WRITEL( comp( FB_READL(src), FB_READL(dst), last), dst);
}
} else {
- // Different alignment for source and dest
+ /* Different alignment for source and dest */
unsigned long d0, d1;
int m;
@@ -121,7 +121,7 @@ bitcpy(unsigned long __iomem *dst, int d
d0 = d0<<left | d1>>right;
}
d0 = fb_rev_pixels_in_long(d0, bswapmask);
- FB_WRITEL( comp(d0, FB_READL(dst), first), dst);
+ FB_WRITEL(comp(d0, FB_READL(dst), first), dst);
} else {
// Multiple destination words
/** We must always remember the last value read, because in case
@@ -148,7 +148,7 @@ bitcpy(unsigned long __iomem *dst, int d
n -= bits - dst_idx;
}
d0 = fb_rev_pixels_in_long(d0, bswapmask);
- FB_WRITEL( comp(d0, FB_READL(dst), first), dst);
+ FB_WRITEL(comp(d0, FB_READL(dst), first), dst);
d0 = d1;
// Main chunk
@@ -186,11 +186,12 @@ bitcpy(unsigned long __iomem *dst, int d
} else {
// 2 source words
d1 = FB_READL(src);
- d1 = fb_rev_pixels_in_long(d1, bswapmask);
+ d1 = fb_rev_pixels_in_long(d1,
+ bswapmask);
d0 = d0<<left | d1>>right;
}
d0 = fb_rev_pixels_in_long(d0, bswapmask);
- FB_WRITEL( comp(d0, FB_READL(dst), last), dst);
+ FB_WRITEL(comp(d0, FB_READL(dst), last), dst);
}
}
}
@@ -289,7 +290,7 @@ bitcpy_rev(unsigned long __iomem *dst, i
d0 = d0>>right | d1<<left;
}
d0 = fb_rev_pixels_in_long(d0, bswapmask);
- FB_WRITEL( comp(d0, FB_READL(dst), first), dst);
+ FB_WRITEL(comp(d0, FB_READL(dst), first), dst);
} else {
// Multiple destination words
/** We must always remember the last value read, because in case
@@ -312,7 +313,7 @@ bitcpy_rev(unsigned long __iomem *dst, i
d0 = d0>>right | d1<<left;
}
d0 = fb_rev_pixels_in_long(d0, bswapmask);
- FB_WRITEL( comp(d0, FB_READL(dst), first), dst);
+ FB_WRITEL(comp(d0, FB_READL(dst), first), dst);
d0 = d1;
dst--;
n -= dst_idx+1;
@@ -352,11 +353,12 @@ bitcpy_rev(unsigned long __iomem *dst, i
} else {
// 2 source words
d1 = FB_READL(src);
- d1 = fb_rev_pixels_in_long(d1, bswapmask);
+ d1 = fb_rev_pixels_in_long(d1,
+ bswapmask);
d0 = d0>>right | d1<<left;
}
d0 = fb_rev_pixels_in_long(d0, bswapmask);
- FB_WRITEL( comp(d0, FB_READL(dst), last), dst);
+ FB_WRITEL(comp(d0, FB_READL(dst), last), dst);
}
}
}
diff -puN drivers/video/fb_draw.h~fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte-checkpatch-fixes drivers/video/fb_draw.h
--- a/drivers/video/fb_draw.h~fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte-checkpatch-fixes
+++ a/drivers/video/fb_draw.h
@@ -85,11 +85,11 @@ pixel_to_pat( u32 bpp, u32 pixel)
static inline unsigned long fb_rev_pixels_in_long(unsigned long val,
u32 bswapmask)
{
- if(bswapmask & 1)
+ if (bswapmask & 1)
val = comp(val >> 1, val << 1, REV_PIXELS_MASK1);
- if(bswapmask & 2)
+ if (bswapmask & 2)
val = comp(val >> 2, val << 2, REV_PIXELS_MASK2);
- if(bswapmask & 3)
+ if (bswapmask & 3)
val = comp(val >> 4, val << 4, REV_PIXELS_MASK4);
}
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
origin.patch
slow-down-printk-during-boot.patch
optimize-x86-page-faults-like-all-other-achitectures-and-kill-notifier-cruft.patch
sparsemem-record-when-a-section-has-a-valid-mem_map.patch
readahead-combine-file_ra_stateprev_index-prev_offset-into-prev_pos.patch
mm-use-pagevec-to-rotate-reclaimable-page.patch
fs-introduce-write_begin-write_end-and-perform_write-aops.patch
nfs-convert-to-new-aops.patch
fs-restore-nobh.patch
memoryless-nodes-introduce-mask-of-nodes-with-memory.patch
memoryless-nodes-fixup-uses-of-node_online_map-in-generic-code.patch
categorize-gfp-flags.patch
bias-the-location-of-pages-freed-for-min_free_kbytes-in-the-same-max_order_nr_pages-blocks.patch
slub-slab-validation-move-tracking-information-alloc-outside-of-melstuff.patch
hugetlbfs-read-support.patch
mm-mempolicyc-cleanups.patch
uml-fix-stub-address-calculations.patch
uml-arch-um-drivers-formatting.patch
ecryptfs-printk-warning-fixes.patch
rtc-cmos-probe-cleanup.patch
tdfxfb-mtrr-support.patch
fbdev-fb_create_modedb-non-static-int-first-=-1.patch
intel-fb-support-for-interlaced-video-modes.patch
export-font_vga_8x16.patch
drivers-video-pmag-ba-fbc-improve-diagnostics.patch
fbcon-logo-disable-logo-at-boot.patch
fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte.patch
fbdev-copyarea-function-taught-to-fully-support-swapped-pixel-order-in-byte-checkpatch-fixes.patch
md-software-raid-autodetect-dev-list-not-array.patch
do-cpu_dead-migrating-under-read_locktasklist-instead-of-write_lock_irqtasklist-fix.patch
intel-iommu-pci-generic-helper-function.patch
intel-iommu-iova-allocation-and-management-routines.patch
intel-iommu-intel-iommu-driver.patch
intel-iommu-iommu-floppy-workaround.patch
jbd-config_jbd_debug-cannot-create-proc-entry-fix.patch
peterz-vs-ext4-mballoc-core.patch
64-bit-i_version-afs-fixes.patch
pnp-use-dev_info-dev_err-etc-in-core-fix.patch
pnp-add-debug-message-for-adding-new-device-fix-fix.patch
r-o-bind-mounts-elevate-write-count-during-entire-ncp_ioctl-fix.patch
slab-api-remove-useless-ctor-parameter-and-reorder-parameters-vs-revoke.patch
revoke-wire-up-i386-system-calls.patch
revoke-vs-git-block.patch
task-containersv11-basic-task-container-framework-fix.patch
task-containersv11-shared-container-subsystem-group-arrays-include-fix.patch
add-containerstats-v3-fix.patch
pid-namespaces-dynamic-kmem-cache-allocator-for-pid-namespaces-fix.patch
pid-namespaces-define-is_global_init-and-is_container_init-fix.patch
pid-namespaces-define-is_global_init-and-is_container_init-versus-x86_64-mm-i386-show-unhandled-signals-v3.patch
lockdep-fix-mismatched-lockdep_depth-curr_chain_hash-checkpatch-fixes.patch
fs-superc-use-list_for_each_entry-instead-of-list_for_each-fix.patch
pid-namespaces-helpers-to-find-the-task-by-its-numerical-ids-fix.patch
pid-namespaces-changes-to-show-virtual-ids-to-user-use-find_task_by_pid_ns-in-places-that-operate-with-virtual-fix.patch
pid-namespaces-changes-to-show-virtual-ids-to-user-use-find_task_by_pid_ns-in-places-that-operate-with-virtual-fix-2.patch
pid-namespaces-changes-to-show-virtual-ids-to-user-use-find_task_by_pid_ns-in-places-that-operate-with-virtual-fix-3.patch
pid-namespaces-changes-to-show-virtual-ids-to-user-fix.patch
cpuset-sched_load_balance-flag-fix.patch
cpusets-decrustify-cpuset-mask-update-code-checkpatch-fixes.patch
memory-controller-memory-accounting-v7-fix.patch
memory-controller-add-per-container-lru-and-reclaim-v7-fix.patch
memory-controller-oom-handling-v7-vs-oom-killer-stuff.patch
memory-controller-add-switch-to-control-what-type-of-pages-to-limit-v7-fix-2.patch
memcontrol-move-oom-task-exclusion-to-tasklist-fix.patch
remove-bits_to_type-macro-fix.patch
use-helpers-to-obtain-task-pid-in-printks-drm-fix.patch
hotplug-cpu-migrate-a-task-within-its-cpuset-fix.patch
cpu-hotplug-avoid-hotadd-when-proper-possible_map-isnt-specified-checkpatch-fixes.patch
powerpc-lock-bitops-fix.patch
ipc-integrate-ipc_checkid-into-ipc_lock-fix.patch
ipc-integrate-ipc_checkid-into-ipc_lock-fix-2.patch
use-extended-crashkernel-command-line-on-i386.patch
ftd_sio-clean-ups-and-updates-for-new-termios-work-checkpatch-fixes.patch
hook-up-group-scheduler-with-control-groups-fix.patch
linux-kernel-markers-checkpatch-fixes.patch
linux-kernel-markers-samples-checkpatch-fixes.patch
uninline-forkc-exitc-checkpatch-fixes.patch
fuse-fix-race-between-getattr-and-write-checkpatch-fixes.patch
fuse-add-file-handle-to-getattr-operation-checkpatch-fixes.patch
sparse-pointer-use-of-zero-as-null-checkpatch-fixes.patch
reiser4.patch
git-block-vs-reiser4.patch
git-nfsd-broke-reiser4.patch
slab-api-remove-useless-ctor-parameter-and-reorder-parameters-vs-reiser4.patch
page-owner-tracking-leak-detector.patch
profile-likely-unlikely-macros-fix.patch
w1-build-fix.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
