+ bw-qcam-use-data_reverse-instead-of-manually-poking-the-control-register-fix.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     bw-qcam-use-data_reverse-instead-of-manually-poking-the-control-register fix
has been added to the -mm tree.  Its filename is
     bw-qcam-use-data_reverse-instead-of-manually-poking-the-control-register-fix.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: bw-qcam-use-data_reverse-instead-of-manually-poking-the-control-register fix
From: "Brett Warden" <brett.warden@xxxxxxxxx>

coding-style repairs

Cc: Brett T. Warden <brett.warden@xxxxxxxxx>
Cc: "Ray Lee" <ray-lk@xxxxxxxxxxxxx>
Cc: Alan Cox <alan@xxxxxxxxxx>
Cc: "Randy.Dunlap" <rdunlap@xxxxxxxxxxxx>
Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/media/video/bw-qcam.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff -puN drivers/media/video/bw-qcam.c~bw-qcam-use-data_reverse-instead-of-manually-poking-the-control-register-fix drivers/media/video/bw-qcam.c
--- a/drivers/media/video/bw-qcam.c~bw-qcam-use-data_reverse-instead-of-manually-poking-the-control-register-fix
+++ a/drivers/media/video/bw-qcam.c
@@ -104,7 +104,7 @@ static inline void write_lpdata(struct q
 
 static inline void write_lpcontrol(struct qcam_device *q, int d)
 {
-	if(0x20 & d) {
+	if (d & 0x20) {
 		/* Set bidirectional mode to reverse (data in) */
 		parport_data_reverse(q->pport);
 	} else {
@@ -355,11 +355,11 @@ static int qc_detect(struct qcam_device 
 	/* Be (even more) liberal in what you accept...  */
 
 /*	if (count > 30 && count < 200) */
-	if (count > 20 && count < 400)
-	{
+	if (count > 20 && count < 400) {
 		return 1;	/* found */
 	} else {
-		printk(KERN_ERR "No Quickcam found on port %s\n", q->pport->name);
+		printk(KERN_ERR "No Quickcam found on port %s\n",
+			q->pport->name);
 		return 0;	/* not found */
 	}
 }
_

Patches currently in -mm which might be from brett.warden@xxxxxxxxx are

bw-qcam-use-data_reverse-instead-of-manually-poking-the-control-register.patch
bw-qcam-use-data_reverse-instead-of-manually-poking-the-control-register-fix.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux