The patch titled misc: fix unterminated *_device_id lists has been added to the -mm tree. Its filename is pci-fix-unterminated-pci_device_id-lists-fix.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: misc: fix unterminated *_device_id lists From: Kees Cook <kees@xxxxxxxxxx> Fixes drivers that do not correctly terminate their *_device_id lists. This results in garbage being spewed into modules.pcimap when the module happens to not have 28 NULL bytes following the table, and/or the last PCI ID is actually truncated from the table when calculating the modules.alias PCI aliases, causing those unfortunate device IDs to not auto-load. Signed-off-by: Kees Cook <kees@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/media/video/usbvision/usbvision-cards.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/media/video/usbvision/usbvision-cards.c~pci-fix-unterminated-pci_device_id-lists-fix drivers/media/video/usbvision/usbvision-cards.c --- a/drivers/media/video/usbvision/usbvision-cards.c~pci-fix-unterminated-pci_device_id-lists-fix +++ a/drivers/media/video/usbvision/usbvision-cards.c @@ -1081,6 +1081,7 @@ struct usb_device_id usbvision_table [] { USB_DEVICE(0x2304, 0x0301), .driver_info=PINNA_LINX_VD_IN_CAB_PAL }, { USB_DEVICE(0x2304, 0x0419), .driver_info=PINNA_PCTV_BUNGEE_PAL_FM }, { USB_DEVICE(0x2400, 0x4200), .driver_info=HPG_WINTV }, + { }, /* terminate list */ }; MODULE_DEVICE_TABLE (usb, usbvision_table); _ Patches currently in -mm which might be from kees@xxxxxxxxxx are pci-fix-unterminated-pci_device_id-lists.patch pci-fix-unterminated-pci_device_id-lists-fix.patch modpost-detect-unterminated-device-id-lists.patch modpost-detect-unterminated-device-id-lists-fix.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html